feat: DH-18149: Simplified passing s3 instructions for iceberg writing #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
malhotrashivam
requested review from
chipkent,
jmao-denver,
rcaudy and
cpwright
as code owners
devinrsmith
reviewed
Mar 3, 2025
extensions/iceberg/src/main/java/io/deephaven/iceberg/util/IcebergTableAdapter.java
Outdated
Show resolved
Hide resolved
...nsions/iceberg/s3/src/test/java/io/deephaven/iceberg/util/TableParquetWriterOptionsTest.java
Outdated
Show resolved
Hide resolved
| @NotNull final DataInstructionsProviderLoader dataInstructionsProvider) { | ||
| super(tableAdapter, instructions, dataInstructionsProvider); | ||
| @NotNull final DataInstructionsProviderLoader dataInstructionsProvider, | ||
| @NotNull final String tableLocationUriScheme) { |
There was a problem hiding this comment.
This is technically a breaking change. One of the reasons why I don't like exposing this as a public interface to consumers. Ditto wrt Base layout and KV layout.
Practically, I think we should make this package private. I know that DHE constructs these directly though, so we need to audit how / why they are using it.
There was a problem hiding this comment.
Good catch. I have made the change non-breaking and created a separate ticket (DH-18831) for investigating into the DHE Iceberg construction logic.
extensions/iceberg/src/main/java/io/deephaven/iceberg/util/IcebergTableWriter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: https://deephaven.atlassian.net/browse/DH-18149
Description:
Previously, users had to provide the S3 configuration (username, password, region, etc.) in two places:
With this PR, if the S3 configuration is not passed when constructing the table writer, it will automatically inherit the configuration from the catalog properties. This change aligns with the existing pattern used for reading iceberg tables.