[Deepin-Kernel-SIG] [Upstream] [linux 6.6-y] Sync some btmtk bugfix from mainline

[opsiff]

Fixes:
commit 1d734a2: ("Bluetooth: btusb: mediatek: add ISO data transmission functions")

Commit:
Bluetooth: btusb: mediatek: Add locks for usb_driver_claim_interface()
Bluetooth: btmtk: adjust the position to init iso data anchor
Bluetooth: btusb: mediatek: change the conditions for ISO interface
Bluetooth: btusb: mediatek: add intf release flow when usb disconnect
Bluetooth: btusb: mediatek: move Bluetooth power off command position

Summary by Sourcery

Fix several bugs related to the MediaTek Bluetooth USB driver, including a potential deadlock, incorrect interface handling, and ISO data transmission issues. Introduce a disconnect handler to release the ISO interface upon disconnection. Adjust the initialization timing of the ISO data anchor and the Bluetooth power off command.

Bug Fixes:

• Fix potential deadlock by adding locks for usb_driver_claim_interface() when called outside of probe routines.
• Fix ISO interface claim condition and add an interface release flow during USB disconnect.
• Fix incorrect positioning of the Bluetooth power off command.
• Fix the initialization timing of the ISO data anchor by moving it after the interface claim to avoid potential issues.
• Fix a bug where ISO packet transmission could fail due to incorrect interface conditions by changing the conditions for ISO interface

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request synchronizes several bug fixes from the mainline kernel related to the MediaTek Bluetooth USB driver (btmtk). These fixes address issues related to claiming and releasing the ISO interface, handling USB disconnects, and power management. The changes involve adding locking, adjusting initialization order, modifying conditional checks, and implementing a disconnect flow.

Sequence diagram for claiming the ISO interface

sequenceDiagram
  participant btusb_mtk_claim_iso_intf
  participant device_lock
  participant usb_driver_claim_interface
  participant device_unlock
  participant set_bit
  participant init_usb_anchor

  btusb_mtk_claim_iso_intf->>device_lock: device_lock(&btmtk_data->isopkt_intf->dev)
  activate device_lock
  device_lock-->>btusb_mtk_claim_iso_intf: 
  deactivate device_lock
  btusb_mtk_claim_iso_intf->>usb_driver_claim_interface: usb_driver_claim_interface(&btusb_driver, btmtk_data->isopkt_intf, data)
  activate usb_driver_claim_interface
  usb_driver_claim_interface-->>btusb_mtk_claim_iso_intf: err
  deactivate usb_driver_claim_interface
  alt err < 0
    btusb_mtk_claim_iso_intf->>btusb_mtk_claim_iso_intf: btmtk_data->isopkt_intf = NULL
    btusb_mtk_claim_iso_intf->>btusb_mtk_claim_iso_intf: bt_dev_err(data->hdev, "Failed to claim iso interface")
  else err >= 0
    btusb_mtk_claim_iso_intf->>set_bit: set_bit(BTMTK_ISOPKT_OVER_INTR, &btmtk_data->flags)
    activate set_bit
    set_bit-->>btusb_mtk_claim_iso_intf: 
    deactivate set_bit
    btusb_mtk_claim_iso_intf->>init_usb_anchor: init_usb_anchor(&btmtk_data->isopkt_anchor)
    activate init_usb_anchor
    init_usb_anchor-->>btusb_mtk_claim_iso_intf: 
    deactivate init_usb_anchor
  end
  btusb_mtk_claim_iso_intf->>device_unlock: device_unlock(&btmtk_data->isopkt_intf->dev)
  activate device_unlock
  device_unlock-->>btusb_mtk_claim_iso_intf: 
  deactivate device_unlock

Loading

File-Level Changes

Change	Details	Files
Added locking around usb_driver_claim_interface() to prevent race conditions when claiming the ISO interface.	Added device_lock() before claiming the ISO interface. Added device_unlock() after claiming the ISO interface.	drivers/bluetooth/btusb.c
Adjusted the position of ISO data anchor initialization.	Moved init_usb_anchor() to be called directly after claiming the ISO interface.	drivers/bluetooth/btusb.c drivers/bluetooth/btmtk.c
Modified the conditions for claiming the ISO interface.	Added a check to ensure the ISO interface is only claimed if it hasn't already been claimed. The ISO interface is now retrieved using usb_ifnum_to_if() only if it hasn't been claimed yet.	drivers/bluetooth/btusb.c
Implemented a flow to release the ISO interface when the USB device is disconnected.	Added a btusb_mtk_disconnect() function that calls btusb_mtk_release_iso_intf() to release the ISO interface. Assigned the btusb_mtk_disconnect function to the disconnect callback in the btusb_probe function.	drivers/bluetooth/btusb.c
Moved the Bluetooth power off command to the shutdown function.	The ISO interface is now released in the shutdown function. The btmtk_usb_shutdown function is called before releasing the ISO interface.	drivers/bluetooth/btusb.c
Refactored the btusb_mtk_release_iso_intf function to accept hci_dev as an argument.	The function now accepts hci_dev instead of btusb_data. The function now uses hci_get_priv to get the btmtk_data struct.	drivers/bluetooth/btusb.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @opsiff - I've reviewed your changes - here's some feedback:

Overall Comments:

• It looks like btusb_mtk_release_iso_intf now takes struct hci_dev *hdev instead of struct btusb_data *data, but the commit message still refers to data.
• Consider adding a comment explaining why btusb_mtk_disconnect is needed.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sourcery-ai[bot]
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment