Accessibility: Use ul/li for recommendation module lists (vufind-org#…

…3315)
demiankatz · Jan 16, 2024 · 64a92e1 · 64a92e1
1 parent c9973f9
commit 64a92e1
Show file tree

Hide file tree

Showing 6 changed files with 26 additions and 26 deletions.
diff --git a/themes/bootstrap3/templates/Recommend/Databases.phtml b/themes/bootstrap3/templates/Recommend/Databases.phtml
@@ -6,27 +6,27 @@
     <?php if ($this->transEsc('databases_recommend_intro', [], '')): ?>
       <p><?=$this->transEsc('databases_recommend_intro')?></p>
     <?php endif; ?>
-    <div class="list-group">
+    <ul class="list-group">
       <?php foreach ($databases as $database): ?>
-        <div class="list-group-item">
+        <li class="list-group-item">
           <span>
             <a href="<?=$this->escapeHtmlAttr($this->proxyUrl($database['url']))?>" class="title icon-link" target="_blank">
               <?=$this->icon('external-link', 'icon-link__icon') ?>
               <span class="icon-link__label"><?=$this->escapeHtml($database['name'])?></span>
             </a>
           </span>
-        </div>
+        </li>
       <?php endforeach; ?>
       <?php if ($linkToAll): ?>
-        <div class="list-group-item">
+        <li class="list-group-item">
           <span>
             <a href="<?=$this->escapeHtmlAttr($this->proxyUrl($linkToAll))?>" class="title icon-link" target="_blank">
               <?=$this->icon('external-link', 'icon-link__icon') ?>
               <span class="icon-link__label"><?=$this->transEsc('databases_recommend_link_to_all')?></span>
             </a>
           </span>
-        </div>
+        </li>
       <?php endif; ?>
-    </div>
+    </ul>
   <?php endif ?>
 </div>
diff --git a/themes/bootstrap3/templates/Recommend/EDSResults.phtml b/themes/bootstrap3/templates/Recommend/EDSResults.phtml
@@ -5,9 +5,9 @@
 ?>
 <?php if (!empty($results)): ?>
   <h2><?=$this->transEsc($heading)?></h2>
-  <div class="list-group">
+  <ul class="list-group">
     <?php foreach ($results as $driver): ?>
-      <div class="list-group-item">
+      <li class="list-group-item">
         <span>
           <?php
             $formats = $driver->getFormats();
@@ -24,8 +24,8 @@
           </span>
           <?php endif; ?>
         </span>
-      </div>
+      </li>
     <?php endforeach; ?>
     <a class="list-group-item" href="<?=$this->url($searchObject->getOptions()->getSearchAction()) . $searchObject->getUrlQuery()->setLimit($searchObject->getOptions()->getDefaultLimit())?>"><?=$this->transEsc('More EDS results')?></a>
-  </div>
+  </ul>
 <?php endif ?>
diff --git a/themes/bootstrap3/templates/Recommend/EPFResults.phtml b/themes/bootstrap3/templates/Recommend/EPFResults.phtml
@@ -5,16 +5,16 @@
 ?>
 <?php if (!empty($results)): ?>
   <h2><?=$this->transEsc($heading)?></h2>
-  <div class="list-group">
+  <ul class="list-group">
     <?php foreach ($results as $driver): ?>
-      <div class="list-group-item">
+      <li class="list-group-item">
         <span>
           <a href="<?=$this->escapeHtmlAttr($this->recordLinker()->getUrl($driver))?>" class="title">
             <?=$this->record($driver)->getTitleHtml()?>
           </a>
         </span>
-      </div>
+      </li>
     <?php endforeach; ?>
     <a class="list-group-item" href="<?=$this->url($searchObject->getOptions()->getSearchAction()) . $searchObject->getUrlQuery()->setLimit($searchObject->getOptions()->getDefaultLimit())?>"><?=$this->transEsc('epf_recommendations_more')?></a>
-  </div>
+  </ul>
 <?php endif ?>
diff --git a/themes/bootstrap3/templates/Recommend/LibGuidesAZResults.phtml b/themes/bootstrap3/templates/Recommend/LibGuidesAZResults.phtml
@@ -5,16 +5,16 @@
 ?>
 <?php if (!empty($results)): ?>
   <h2><?=$this->transEsc($heading)?></h2>
-  <div class="list-group">
+  <ul class="list-group">
     <?php foreach ($results as $driver): ?>
-      <div class="list-group-item">
+      <li class="list-group-item">
         <span>
           <a href="<?=$this->escapeHtmlAttr($driver->getUniqueID())?>" class="title">
             <?=$this->record($driver)->getTitleHtml()?>
           </a>
         </span>
-      </div>
+      </li>
     <?php endforeach; ?>
     <a class="list-group-item" href="<?=$this->url($searchObject->getOptions()->getSearchAction()) . $searchObject->getUrlQuery()->setLimit($searchObject->getOptions()->getDefaultLimit())?>"><?=$this->transEsc('libguidesaz_recommendations_more')?></a>
-  </div>
+  </ul>
 <?php endif ?>
diff --git a/themes/bootstrap3/templates/Recommend/LibGuidesResults.phtml b/themes/bootstrap3/templates/Recommend/LibGuidesResults.phtml
@@ -5,16 +5,16 @@
 ?>
 <?php if (!empty($results)): ?>
   <h2><?=$this->transEsc($heading)?></h2>
-  <div class="list-group">
+  <ul class="list-group">
     <?php foreach ($results as $driver): ?>
-      <div class="list-group-item">
+      <li class="list-group-item">
         <span>
           <a href="<?=$this->escapeHtmlAttr($driver->getUniqueID())?>" class="title">
             <?=$this->record($driver)->getTitleHtml()?>
           </a>
         </span>
-      </div>
+      </li>
     <?php endforeach; ?>
     <a class="list-group-item" href="<?=$this->url($searchObject->getOptions()->getSearchAction()) . $searchObject->getUrlQuery()->setLimit($searchObject->getOptions()->getDefaultLimit())?>"><?=$this->transEsc('libguides_recommendations_more')?></a>
-  </div>
+  </ul>
 <?php endif ?>
diff --git a/themes/bootstrap3/templates/Recommend/SummonResults.phtml b/themes/bootstrap3/templates/Recommend/SummonResults.phtml
@@ -3,9 +3,9 @@
 <?php $heading = $this->recommend->getHeading(); ?>
 <?php if (!empty($results)): ?>
   <h2><?=$this->transEsc($heading)?></h2>
-  <div class="list-group">
+  <ul class="list-group">
     <?php foreach ($results as $driver): ?>
-      <div class="list-group-item">
+      <li class="list-group-item">
         <span>
           <?php
             $formats = $driver->getFormats();
@@ -22,8 +22,8 @@
           </span>
           <?php endif; ?>
         </span>
-      </div>
+      </li>
     <?php endforeach; ?>
     <a class="list-group-item" href="<?=$this->url($searchObject->getOptions()->getSearchAction()) . $searchObject->getUrlQuery()->setLimit($searchObject->getOptions()->getDefaultLimit())?>"><?=$this->transEsc('More Summon results')?></a>
-  </div>
+  </ul>
 <?php endif ?>