Disable hidden filters completely for New Items.

demiankatz · Jan 17, 2025 · 7d67a7d · 7d67a7d
1 parent 5e148ae
commit 7d67a7d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/module/VuFind/src/VuFind/Controller/SearchController.php b/module/VuFind/src/VuFind/Controller/SearchController.php
@@ -316,6 +316,7 @@ public function newitemresultsAction()
         }
 
         // We don't want new items hidden filters to propagate to other searches:
+        $this->serviceLocator->get('ViewHelperManager')->get('searchTabs')->disableHiddenFilterParams();
         $view->ignoreHiddenFiltersInRequest = true;
 
         return $view;

diff --git a/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php b/module/VuFind/src/VuFind/View/Helper/Root/SearchTabs.php
@@ -85,6 +85,13 @@ class SearchTabs extends \Laminas\View\Helper\AbstractHelper
      */
     protected $cachedHiddenFilterParams = [];
 
+    /**
+     * Are hidden filter params disabled?
+     *
+     * @var bool
+     */
+    protected $hiddenFilterParamsDisabled = false;
+
     /**
      * Constructor
      *
@@ -229,6 +236,9 @@ public function getCurrentHiddenFilterParams(
         $ignoreHiddenFilterMemory = false,
         $prepend = '&amp;'
     ) {
+        if ($this->hiddenFilterParamsDisabled) {
+            return '';
+        }
         if (!isset($this->cachedHiddenFilterParams[$searchClassId])) {
             $view = $this->getView();
             $hiddenFilters = $this->getHiddenFilters(
@@ -371,4 +381,15 @@ protected function buildUrlHiddenFilters(
         }
         return '';
     }
+
+    /**
+     * Disable hidden filter params (used in contexts like New Items where we don't
+     * want to persist hidden filters through links).
+     *
+     * @return void
+     */
+    public function disableHiddenFilterParams(): void
+    {
+        $this->hiddenFilterParamsDisabled = true;
+    }
 }