Resource Service Migration #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @skellamp! I've merged the latest upstream changes into this PR and run the full test suite, and everything is passing. The work looks good as well! I'm going to do some careful hands-on testing over the next couple of days as time permits. I'll let you know if I find any problems; otherwise, I'll merge this once I've checked everything out. |
demiankatz
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Thanks, @skellamp, I can't find anything to improve upon here. You've known me long enough to know that it's kind of hard for anyone to ask me to review a PR and not get at least some small picky bit of feedback, so congratulations on this achievement. ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.