Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tsc): split TS compiler into multiple files, use ESM #27784

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

bartlomieju
Copy link
Member

This is a pure refactor, the 99_main_compiler.js file
was getting out of hand, being over 1500 lines and serving
3 distinct purposes:

  • snapshotting
  • type-checking
  • running LSP

The file was split into:

  • 97_ts_host.js
  • 98_lsp.js
  • 99_main_compiler.js

Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/build.rs Show resolved Hide resolved
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit ab18dac into denoland:main Jan 23, 2025
17 checks passed
@bartlomieju bartlomieju deleted the tsc_esm branch January 23, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants