Tidied up timeout

deploymenttheory · Mar 4, 2025 · f9d0df9 · f9d0df9
1 parent c08b825
commit f9d0df9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/httpclient/client.go b/httpclient/client.go
@@ -17,6 +17,8 @@ import (
 	"go.uber.org/zap"
 )
 
+const DefaultTimeout time.Duration = 5 * time.Second
+
 // Master struct/object
 type Client struct {
 	config      *ClientConfig
@@ -105,6 +107,12 @@ func (c *ClientConfig) Build() (*Client, error) {
 
 	httpClient := c.HTTP
 
+	if c.CustomTimeout == 0 {
+		c.CustomTimeout = DefaultTimeout
+	}
+
+	httpClient.Timeout = c.CustomTimeout
+
 	cookieJar, err := cookiejar.New(nil)
 	if err != nil {
 		return nil, err
@@ -127,6 +135,8 @@ func (c *ClientConfig) Build() (*Client, error) {
 		)
 	}
 
+
+
 	client := &Client{
 		Integration: &c.Integration,
 		http:        &httpClient,

diff --git a/httpclient/request.go b/httpclient/request.go
@@ -272,10 +272,6 @@ func (c *Client) request(ctx context.Context, method, endpoint string, body inte
 
 	req = req.WithContext(ctx)
 
-	// TEMPORARY HARD CODED TIMEOUT
-	c.http.Timeout = 5 * time.Second
-	////////////////////////////////
-
 	resp, err := c.http.Do(req)
 	if err != nil {
 		c.Sugar.Error("Failed to send request", zap.String("method", method), zap.String("endpoint", endpoint), zap.Error(err))