chart: introduce v1-data-engine setting

Longhorn 7095 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit · Dec 26, 2023 · 73a4516 · 73a4516
1 parent 71d812f
commit 73a4516
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 1 deletion.
diff --git a/chart/README.md b/chart/README.md
@@ -322,6 +322,7 @@ For more details like types or options, you can refer to **Settings Reference**
 | defaultSettings.systemManagedPodsImagePullPolicy | This setting defines the Image Pull Policy of Longhorn system managed pod. E.g. instance manager, engine image, CSI driver, etc. The new Image Pull Policy will only apply after the system-managed pods restart. |
 | defaultSettings.taintToleration | taintToleration for Longhorn system-managed components |
 | defaultSettings.upgradeChecker | Upgrade Checker will check for a new Longhorn version periodically. When there is a new version available, a notification will appear in the UI. By default, true. |
+| defaultSettings.v1DataEngine | Setting that allows you to enable the V1 Data Engine. |
 | defaultSettings.v2DataEngine | This allows users to activate v2 data engine based on SPDK. Currently, it is in the preview phase and should not be utilized in a production environment. |
 
 ---

diff --git a/chart/questions.yaml b/chart/questions.yaml
@@ -652,6 +652,12 @@ questions:
   group: "Longhorn Default Settings"
   type: boolean
   default: true
+- variable: defaultSettings.v1DataEngine
+  label: V1 Data Engine
+  description: "Setting that allows you to enable the V1 Data Engine."
+  group: "Longhorn V1 Data Engine Settings"
+  type: boolean
+  default: true
 - variable: defaultSettings.v2DataEngine
   label: V2 Data Engine
   description: "This allows users to activate v2 data engine based on SPDK. Currently, it is in the preview phase and should not be utilized in a production environment."

diff --git a/chart/templates/default-setting.yaml b/chart/templates/default-setting.yaml
@@ -197,6 +197,9 @@ data:
     {{- if not (kindIs "invalid" .Values.defaultSettings.restoreConcurrentLimit) }}
     restore-concurrent-limit: {{ .Values.defaultSettings.restoreConcurrentLimit }}
     {{- end }}
+    {{- if not (kindIs "invalid" .Values.defaultSettings.v1DataEngine) }}
+    v1-data-engine: {{ .Values.defaultSettings.v1DataEngine }}
+    {{- end }}
     {{- if not (kindIs "invalid" .Values.defaultSettings.v2DataEngine) }}
     v2-data-engine: {{ .Values.defaultSettings.v2DataEngine }}
     {{- end }}

diff --git a/chart/values.yaml b/chart/values.yaml
@@ -328,7 +328,9 @@ defaultSettings:
   backupConcurrentLimit: ~
   # -- This setting controls how many worker threads per restore concurrently.
   restoreConcurrentLimit: ~
-  # -- This allows users to activate v2 data engine based on SPDK.
+  # -- Setting that allows you to enable the V1 Data Engine. By default, true.
+  v1DataEngine: ~
+  # -- This allows users to activate v2 data engine based on SPDK. By default, false.
   # Currently, it is in the preview phase and should not be utilized in a production environment.
   v2DataEngine: ~
   # -- This setting allows users to enable the offline replica rebuilding for volumes using v2 data engine.

diff --git a/deploy/upgrade_responder_server/chart-values.yaml b/deploy/upgrade_responder_server/chart-values.yaml
@@ -207,6 +207,10 @@ configMap:
           "dataType": "string",
           "maxLen": 200
         },
+        "longhornSettingV1DataEngine": {
+          "dataType": "string",
+          "maxLen": 200
+        }
         "longhornSettingV2DataEngine": {
           "dataType": "string",
           "maxLen": 200

diff --git a/dev/upgrade-responder/install.sh b/dev/upgrade-responder/install.sh
@@ -224,6 +224,10 @@ configMap:
           "dataType": "string",
           "maxLen": 200
         },
+        "longhornSettingV1DataEngine": {
+          "dataType": "string",
+          "maxLen": 200
+        }
         "longhornSettingV2DataEngine": {
           "dataType": "string",
           "maxLen": 200