Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save new users a lot of pain from rug pullers #142

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

addanus
Copy link

@addanus addanus commented Jun 13, 2021

At onboarding, users are excited to get started, but the first thing they HAVE to do is update their profile.
The initial FR should not be anything other than 100% at this point in the process!

If changed from 100% at this first opportunity, scammers using auto-bots quickly purchase before users are able to buy their coin.
Before they know it, upon trying to take their 2nd action, their coin price has increased and any $ they put in goes directly into the hands of the owners of the bots.

This 1 change is a must imho to improve the user experience of new clouters.

At onboarding, users are excited to get started, but the first thing they HAVE to do is update their profile. 
The initial FR should not be anything other than 100% at this point in the process!

If changed from 100% at this first opportunity, scammers using auto-bots quickly purchase before users are able to buy their coin.
Before they know it, upon trying to take their 2nd action, their coin price has increased and any $ they put in goes directly into the hands of the owners of the bots.

This 1 change is a must imho to improve the user experience of new clouters.
@addanus addanus requested a review from a team as a code owner June 13, 2021 16:20
"A value of 0% means no value gets rewarded to you for each coin purchased, " +
"whereas a value of 100% means no one other than you gets the value because 100% " +
"goes to you.\n\nSetting it too high will deter others from " +
"buying your coin. Setting it too low risks 'rug-pullers' profitting off of " +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo the sentence with "rug-pullers" should be rephrased (first-time people have no idea of this dynamic).

@lazynina
Copy link
Member

At onboarding, users are excited to get started, but the first thing they HAVE to do is update their profile.
The initial FR should not be anything other than 100% at this point in the process!

If changed from 100% at this first opportunity, scammers using auto-bots quickly purchase before users are able to buy their coin.
Before they know it, upon trying to take their 2nd action, their coin price has increased and any $ they put in goes directly into the hands of the owners of the bots.

This 1 change is a must imho to improve the user experience of new clouters.

the founder's reward is already 100% when first updating a profile so I don't believe this change is necessary.

@@ -170,7 +169,7 @@ export class UpdateProfileComponent implements OnInit, OnChanges {
this.profileUpdates.usernameUpdate /*NewUsername*/,
this.profileUpdates.descriptionUpdate /*NewDescription*/,
this.profileUpdates.profilePicUpdate /*NewProfilePic*/,
this.founderRewardInput * 100 /*NewCreatorBasisPoints*/,
this.founderRewardInput * 1000 /*NewCreatorBasisPoints*/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in basis points, so multiplying by 1000 will result in an error. You can't have a founder's reward > 100%.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! I knew I should have reviewed that more closely. It was a last minute quick addition. Sry!!! The text should be updated at least.

@addanus
Copy link
Author

addanus commented Jun 22, 2021

@maebeam ... bump?

@maebeam
Copy link
Contributor

maebeam commented Jun 22, 2021

I think we'd like to make this flow a little bit more user friendly as very few users read this copy at all. While I'm not opposed to the copy change I would like to run it by @diamondhands0 first.

@addanus
Copy link
Author

addanus commented Jun 22, 2021

Sounds good. Y'all have a knack for smart fixes for identified problems, so if this goes away but some UI friendly solution takes its place, great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants