fixed import issue and bumped to v1.0.4

devaa-security · Apr 16, 2023 · 4fd1c40 · 4fd1c40
1 parent 77c83cd
commit 4fd1c40
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 11 deletions.
diff --git a/manifest-scanner/package.json b/manifest-scanner/package.json
@@ -1,6 +1,6 @@
 {
   "name": "manifest-scanner",
-  "version": "1.0.2",
+  "version": "1.0.4",
   "description": "Manifest Scanner for Android Application",
   "author": "Shivasurya @s5dev",
   "bin": {

diff --git a/manifest-scanner/src/commands/scan.ts b/manifest-scanner/src/commands/scan.ts
@@ -1,6 +1,6 @@
 import { Args, Command, Flags } from "@oclif/core";
 import { findFileInDirectory, parseXmlFileToJson } from "../utils/fileutils";
-import ManifestPlugin from "../plugins/ManifestPlugin";
+import { ManifestPlugin } from "../plugins/ManifestPlugin";
 import path = require("path");
 const fs = require("fs/promises");
 
@@ -72,7 +72,8 @@ export default class Scan extends Command {
               const files = await fs.readdir(folder);
               for (const file of files) {
                 //    console.log(folder + "/" + file);
-                let filePath = path.join(__dirname, "..", 'plugins', 'manifest', file);
+                let fileWithoutExtension = file.split(".")[0];
+                let filePath = path.join(__dirname, "..", 'plugins', 'manifest', fileWithoutExtension);
                 const { default: Rule } = await import(
                   filePath
                 );

diff --git a/manifest-scanner/src/plugins/ManifestPlugin.ts b/manifest-scanner/src/plugins/ManifestPlugin.ts
@@ -44,3 +44,5 @@ export default abstract class ManifestPlugin extends BasePlugin {
 
   abstract run(): void; // User should define how their plugin runs
 }
+
+export { ManifestPlugin };
diff --git a/manifest-scanner/src/plugins/manifest/APIKeysRule.ts b/manifest-scanner/src/plugins/manifest/APIKeysRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 import * as fs from "fs";
 

diff --git a/manifest-scanner/src/plugins/manifest/AllowBackupRule.ts b/manifest-scanner/src/plugins/manifest/AllowBackupRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, searchKeywordInFile, getRelativePath } from "../util";
 
 // write a rule to check if the allowBackup attribute is set to true or false inside class AllowBackupRule extended from BaseRule implemeting run method

diff --git a/manifest-scanner/src/plugins/manifest/AndroidDebuggableRule.ts b/manifest-scanner/src/plugins/manifest/AndroidDebuggableRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 
 // write a rule to check if the allowBackup attribute is set to true or false inside class AndroidDebuggable extended from BaseRule implemeting run method

diff --git a/manifest-scanner/src/plugins/manifest/CustomPermissionRule.ts b/manifest-scanner/src/plugins/manifest/CustomPermissionRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 
 // write a rule to check if the custom permission tag is available

diff --git a/manifest-scanner/src/plugins/manifest/ExportedComponentRule.ts b/manifest-scanner/src/plugins/manifest/ExportedComponentRule.ts
@@ -1,5 +1,5 @@
 import { BaseJavaCstVisitorWithDefaults } from "java-parser";
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 import { getJavaFiles } from "../../utils/fileutils";
 const { parse } = require("java-parser");

diff --git a/manifest-scanner/src/plugins/manifest/SingleTaskLaunchModeRule.ts b/manifest-scanner/src/plugins/manifest/SingleTaskLaunchModeRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 
 export default class SingleTaskLaunchModeRule extends ManifestPlugin {

diff --git a/manifest-scanner/src/plugins/manifest/TaskReparentingRule.ts b/manifest-scanner/src/plugins/manifest/TaskReparentingRule.ts
@@ -1,4 +1,4 @@
-import ManifestPlugin from "../ManifestPlugin";
+import { ManifestPlugin } from "../ManifestPlugin";
 import { Severity, getRelativePath, searchKeywordInFile } from "../util";
 
 export default class TaskReParentingRule extends ManifestPlugin {

diff --git a/manifest-scanner/tsconfig.json b/manifest-scanner/tsconfig.json
@@ -6,7 +6,8 @@
     "outDir": "dist",
     "rootDir": "src",
     "strict": true,
-    "target": "es2019"
+    "target": "es2019",
+    "esModuleInterop": true,
   },
   "include": ["src/**/*"]
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -44,3 +44,5 @@ export default abstract class ManifestPlugin extends BasePlugin {

		abstract run(): void; // User should define how their plugin runs
		}

		export { ManifestPlugin };