Skip to content

Commit

Permalink
Expand note about xmlstarlet decompression
Browse files Browse the repository at this point in the history
According to https://gitlab.gnome.org/GNOME/libxml2/-/issues/848#note_2333727,
transparent decompression will be removed from libxml2 which will affect
xmlstarlet.
  • Loading branch information
dfandrich committed Jan 29, 2025
1 parent 10afab9 commit 1cb5ad3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion autodescribe
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,9 @@ comment_svg () {

# File type: svgz (Compressed Scalable Vector Graphics image)
# requires: gzip, xmlstarlet
# TODO: xmlstarlet can transparently gzip-decompress, so replace with comment_svg
# TODO: xmlstarlet can optionally transparently decompress, but that feature is
# likely to be removed some time after 2025 so we shouldn't rely on it here (or
# for certain other file types).
comment_svgz () {
COMMENT=$(gzip -dc < "$1" | xmlstarlet sel -t -v "/*[local-name()='svg']/*[local-name()='title']" 2> /dev/null)
if [ -z "$COMMENT" ] ; then
Expand Down

0 comments on commit 1cb5ad3

Please sign in to comment.