Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/RFC] Multi-selection #103

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

techydude0713
Copy link
Contributor

@techydude0713 techydude0713 commented May 21, 2023

Edit: I didn't implement this for the CLI yet, will do so soon.


Based off of PR #102
A rework of multiselect, using more Qt functionality (I had no idea the feature was a thing, so thanks @dhtdht020!)
Changes from the previous PR:

  • No INI support, this will done at a later point
  • Change the list style into a checkable list
  • Simplified functionality (Although it seems like many edits, it's mostly indenting)
  • The font issue was fixed (caused by me in the previous PR).
    • When using Qt Designer/Creator, it automatically changed the font property to my system's default font.
    • This causes Windows to use it's default font, instead of Segoe UI.

The functions originally created were reused, but with slight modification, especially for the use of item checkboxes.

I did see that Qt has a multiselect feature, but I wasn't happy with how it looked.
(Personally, I liked the colored boxes that represents the download status).

Screen Shot 2023-05-21 at 5 52 45 PM

@dhtdht020 dhtdht020 added the enhancement New feature or request label May 21, 2023
@techydude0713
Copy link
Contributor Author

For the CLI, should apps be individual parameters (oscdl.py get app1 app2 ...), use a simple text file (oscdl.py get apps.txt), or both?

@dhtdht020
Copy link
Owner

For the CLI, should apps be individual parameters (oscdl.py get app1 app2 ...), use a simple text file (oscdl.py get apps.txt), or both?

individual parameters sounds proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants