Skip to content

Commit

Permalink
feat(auth/package.json): add @dictybase/ui-common as a dependency
Browse files Browse the repository at this point in the history
The @dictybase/ui-common package was added as a dependency in the auth
package to provide common UI components across different packages. This
led to the refactoring of the import statement in Private.tsx, replacing
@dictybase/ui-dsc with @dictybase/ui-common for LoadingDisplay. This
change ensures that all UI components are imported from the same
package, improving consistency and maintainability. The nanoid
dependency was removed from the news-component package as it was no
longer being used, reducing the package's size and complexity.
  • Loading branch information
cybersiddhu committed Feb 12, 2024
1 parent 14caf1b commit c32fcb5
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions packages/auth/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
},
"dependencies": {
"@dictybase/header": "*",
"@dictybase/ui-common": "*",
"@logto/react": "^2.1.2",
"react-router-dom": "~6.14.2",
"ts-pattern": "4.x"
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/src/Private.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Outlet } from "react-router-dom"
import { match } from "ts-pattern"
import { LoadingDisplay } from "@dictybase/ui-dsc"
import { LoadingDisplay } from "@dictybase/ui-common"
import { UnAuthorized } from "./UnAuthorized"
import { useAuthorization } from "./useAuthorization"

Expand Down
1 change: 0 additions & 1 deletion packages/news-component/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"dicty-graphql-schema": "dictybase/dicty-graphql-schema",
"jotai": "^1.12.0",
"lexical": "0.11.x",
"nanoid": "^4.0.2",
"react": "17.x",
"react-dom": "17.x",
"react-router-dom": "~6.14.2",
Expand Down

0 comments on commit c32fcb5

Please sign in to comment.