Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling fix/latest-papers-link into develop #670

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

…mponent URL

The unnecessary interpolation in the Link component URL has been removed to fix the url to the single publication route.
Copy link

coderabbitai bot commented Feb 29, 2024

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

…editing editable content pages

The changes introduce new components for handling different aspects of the editable pages feature. The AddPageEditor component allows authorized users to add a new page by providing necessary information and saving it. The ContentEditor component renders the view for editable content pages, displaying the content in a read-only mode. The EditEditor component allows authorized users to edit existing content pages by providing updated content and saving the changes. The EditableEditor component renders editable content pages with a toolbar displaying information about the last update. These components enhance the functionality and user experience of the editable pages feature.
refactor: replace Editor with Editors specific to each view.

The changes were made to improve code readability and maintainability. The unused imports and variables were removed, and the components were refactored to use more descriptive names. Wrapping the components in a Container component provides consistent styling and layout across the application.
…olbar

This commit adds new components to the ui-common package. The components added are:
- AddPageEditor
- ContentEditor
- EditableEditor
- EditEditor
- EditableContentToolbar

These components are useful for building editable pages and provide additional functionality for editing content and managing the toolbar.
…tainer component to allow for wider content

The maxWidth value in the Container component has been changed from "lg" to "xl" to allow for wider content. This change improves the layout of the FrontPageApp component by providing more space for the content within the Container.
…EditableEditor, ContentView to ContentEditor

These components have been swapped to versions without any layout stylings. The previously used components were wrapped in Containers that had stylings for margins. In the context of DSC landing page, these margins are not necessary and detracted from the appearance of the editable content.
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.75%. Comparing base (bdefbd4) to head (5a7fc7e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #670      +/-   ##
===========================================
+ Coverage    94.73%   94.75%   +0.01%     
===========================================
  Files          190      192       +2     
  Lines        14199    14234      +35     
  Branches       492      494       +2     
===========================================
+ Hits         13452    13487      +35     
  Misses         747      747              
Files Coverage Δ
...ages/ui-common/src/EditablePages/ContentEditor.tsx 100.00% <100.00%> (ø)
...ckages/ui-common/src/EditablePages/ContentView.tsx 100.00% <100.00%> (ø)
...ges/ui-common/src/EditablePages/EditableEditor.tsx 100.00% <100.00%> (ø)
...kages/ui-common/src/EditablePages/EditableView.tsx 100.00% <100.00%> (ø)

@ktun95 ktun95 merged commit 415545e into develop Feb 29, 2024
5 checks passed
@ktun95 ktun95 deleted the fix/latest-papers-link branch February 29, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant