Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling feat/genomepage-empty-display into develop #971

Merged
merged 34 commits into from
Feb 4, 2025

style(genomepage): fix various linting errors

fd956f0
Select commit
Loading
Failed to load commit list.
Merged

Pulling feat/genomepage-empty-display into develop #971

style(genomepage): fix various linting errors
fd956f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 0s

89.99% (+2.06%) compared to 1d96963

View this Pull Request on Codecov

89.99% (+2.06%) compared to 1d96963

Details

Codecov Report

Attention: Patch coverage is 41.37931% with 34 lines in your changes missing coverage. Please review.

Project coverage is 89.99%. Comparing base (1d96963) to head (fd956f0).
Report is 23 commits behind head on develop.

Files with missing lines Patch % Lines
...genome-page/components/errors/GraphQLErrorPage.tsx 0.00% 30 Missing ⚠️
apps/genome-page/components/NoDataDisplay.tsx 72.72% 3 Missing ⚠️
...e/components/features/Summary/SummaryContainer.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #971      +/-   ##
===========================================
+ Coverage    87.93%   89.99%   +2.06%     
===========================================
  Files          361      307      -54     
  Lines        19221    18633     -588     
  Branches       792      784       -8     
===========================================
- Hits         16902    16769     -133     
+ Misses        2318     1861     -457     
- Partials         1        3       +2     
Files with missing lines Coverage Δ
apps/genome-page/components/Loader.tsx 100.00% <100.00%> (ø)
...ps/genome-page/components/errors/NotFoundError.tsx 0.00% <ø> (ø)
apps/genome-page/components/errors/OtherError.tsx 70.00% <100.00%> (ø)
apps/genome-page/components/errors/ServerError.tsx 0.00% <ø> (ø)
...components/features/Ontology/OntologyContainer.tsx 100.00% <100.00%> (ø)
...onents/features/Phenotypes/PhenotypesContainer.tsx 100.00% <100.00%> (ø)
...e/components/features/Summary/SummaryContainer.tsx 94.44% <75.00%> (-5.56%) ⬇️
apps/genome-page/components/NoDataDisplay.tsx 72.72% <72.72%> (ø)
...genome-page/components/errors/GraphQLErrorPage.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes