Pulling feat/upload-filename into develop #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #997 +/- ##
========================================
Coverage 90.16% 90.16%
========================================
Files 316 316
Lines 18893 18893
Branches 800 801 +1
========================================
Hits 17035 17035
Misses 1855 1855
Partials 3 3 🚀 New features to boost your workflow:
|
This commit upgrades the dicty-graphql-schema dependency to version v1.29.0 in multiple packages. This ensures that all packages are using the latest version of the schema.
…into Upload component The SelectedFile component is created to display the name of the selected file in the Upload component. The Upload component is updated to use the SelectedFile component to display the name of the selected file. This improves the user interface by providing a dedicated component for displaying the selected file name.
The code is refactored to use `Omatch` instead of `isSome` and `Bmatch` from the `fp-ts/boolean` module. This simplifies the code and makes it more readable. `Omatch` directly handles both the `Some` and `None` cases of an `Option`, which eliminates the need for a separate `isSome` check and `Bmatch` call.
This commit introduces a new `UploadButton` component and refactors the `Upload` component to use it. This improves code organization and reusability. The `UploadButton` component encapsulates the button rendering logic, making the `Upload` component more focused on its primary responsibility of managing the upload process.
Adds a new plop generator to create React component scaffolds. This includes: - A new `create:component` script in `package.json` to run the generator. - A `plop-templates/reactComponent.hbs` template file for the component. - New prompts and actions in `plopfile.js` to handle component generation. This change allows developers to quickly create new React components with a basic structure, improving development speed and consistency.
This change introduces the `uploadName` variable to the `uploadMutation` function. This allows specifying the name under which the file is uploaded, providing more control over the upload process.
Added jsdoc comments to describe the parameters of the `createFileUploadFunction` function. This improves the readability and maintainability of the code.
Adds a new feature to the FileUploadDialog component that allows users to specify a custom filename for the uploaded file. This filename is stored in the `uploadAsFileName` state variable and passed to the `createFileUploadFunction` function. The `Upload` component is also updated to include a new prop for setting the `uploadAsFileName`. This change allows users to have more control over the naming of their uploaded files.
Adds a new text field to the upload dialog that allows the user to specify the name of the file that will be downloaded. The file name input is only visible when a file has been selected. The file name is stored in the `uploadAsName` state variable, which is updated when the user types in the text field. This change allows the user to control the name of the file that is downloaded, which can be useful for providing a more descriptive or user-friendly file name.
The ChangeEventHandler import from react was not being used in the component, so it was removed to clean up the code.
ktun95
force-pushed
the
feat/upload-filename
branch
from
29fb85e to
7d11cef
Compare
…UploadForm The initialFileName prop was removed from the FileUploadForm component. The value was piped from the fileName state using an Option getter, but this logic is not needed anymore. The component now handles the file name internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.