-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulling fix/remove-download-link into develop #998
Conversation
This commit replaces the custom DownloadLinkNode with the standard LinkNode from Lexical. It removes the file name input and simplifies the component to only handle the link text. The DownloadLinkNode was adding unneeded complexity, as the download attribute can be set directly on the LinkNode. This change simplifies the code and makes it easier to maintain.
This change removes the DownloadLinkNode and its related code from the editor configuration. The DownloadLinkNode was a custom node that extended the LinkNode to handle download links. However, it was decided that this functionality was not needed, so the node and its related code were removed to simplify the editor configuration.
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #998 +/- ##
========================================
Coverage 90.16% 90.16%
========================================
Files 316 316
Lines 18893 18893
Branches 800 801 +1
========================================
Hits 17035 17035
- Misses 1855 1857 +2
+ Partials 3 1 -2 🚀 New features to boost your workflow:
|
No description provided.