Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve typescript issues and update request-invoice-web dependencies #14

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 7, 2025

TypeScript and Build Fixes

This PR addresses TypeScript issues in the desktop package and fixes build issues in the request-invoice-web package:

Desktop Package Fixes

  1. Fixed ExtendedInvoice interface in invoice-agent.tsx:

    • Updated to use sellerInfo instead of businessInfo
    • Added proper type assertions and fallback values
    • Aligned with invoice-form.tsx implementation
  2. Fixed BusinessAgent usage in use-business-agent hook:

    • Removed incorrect constructor usage
    • Simplified hook to match Agent interface
    • Removed non-existent methods
  3. Added ensureHyperscrollDir implementation in preload.ts

Request Invoice Web Package Fixes

  1. Updated package dependencies to stable versions:

    • React: ^18.2.0 (from ^19.0.0)
    • Next.js: 13.4.0 (from 15.1.3)
    • Updated related type definitions and ESLint config
  2. Fixed font configuration:

    • Replaced non-existent Geist fonts with Inter from Google Fonts
    • Updated layout.tsx to use Inter font configuration
  3. Updated TypeScript configuration for Next.js 13.4 compatibility

Notes

  • All TypeScript checks pass successfully
  • Request Invoice Web package now builds successfully
  • Changes maintain type safety while fixing interface mismatches
  • Non-critical warnings about node-fetch 'encoding' module are present but don't affect functionality

Link to Devin run: https://app.devin.ai/sessions/524ce5fcc825422faaaddbfd0931f47c

- Update ExtendedInvoice interface to use sellerInfo instead of businessInfo
- Fix BusinessAgent usage in use-business-agent hook
- Add ensureHyperscrollDir implementation in preload.ts

Co-Authored-By: ben <ben@prologe.io>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hypr-v0-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 2:12pm
hyprsqrl-request-invoice-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 2:12pm

@devin-ai-integration devin-ai-integration bot changed the title fix: resolve typescript issues in desktop package fix: resolve typescript issues and update request-invoice-web dependencies Jan 7, 2025
@benjaminshafii benjaminshafii merged commit b1f21b4 into main Jan 7, 2025
2 of 4 checks passed
@benjaminshafii benjaminshafii deleted the devin/1736243872-fix-typescript-issues branch January 16, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant