Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ecdsa multikey support. #54

Merged
merged 24 commits into from
Apr 3, 2023
Merged

Add ecdsa multikey support. #54

merged 24 commits into from
Apr 3, 2023

Conversation

JSAssassin
Copy link
Contributor

No description provided.

@JSAssassin JSAssassin marked this pull request as ready for review March 31, 2023 19:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2023

Codecov Report

Merging #54 (0af7ae4) into main (ca4b973) will increase coverage by 0.97%.
The diff coverage is 97.63%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   96.38%   97.36%   +0.97%     
==========================================
  Files           2        4       +2     
  Lines         304      379      +75     
==========================================
+ Hits          293      369      +76     
+ Misses         11       10       -1     
Impacted Files Coverage Δ
lib/helpers.js 96.11% <96.11%> (ø)
lib/DidKeyDriver.js 97.34% <100.00%> (+1.21%) ⬆️
lib/index.js 100.00% <100.00%> (ø)
lib/util.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JSAssassin JSAssassin requested a review from dlongley April 2, 2023 22:19
`verificationKeyPair` and setting `verificationKeyPair.id`.
@JSAssassin JSAssassin requested a review from dlongley April 3, 2023 15:30
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few minor suggestions.

@dlongley dlongley merged commit afd24e6 into main Apr 3, 2023
@dlongley dlongley deleted the add-ecdsa-support branch April 3, 2023 16:40
@dlongley dlongley mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants