Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed royal road watermark issue. #2531 #2532

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Fixed royal road watermark issue. #2531 #2532

merged 3 commits into from
Jan 2, 2025

Conversation

zGadli
Copy link
Contributor

@zGadli zGadli commented Dec 29, 2024

No description provided.

@Xampa5
Copy link

Xampa5 commented Dec 29, 2024

I suspect deleting every <div> across Royal Road will lead to incomplete scrapping on some novels, as Royal Road authors are allowed to use HTML tags.
Example: https://www.royalroad.com/fiction/25225/delve/chapter/368068/004-statistics

@zGadli
Copy link
Contributor Author

zGadli commented Dec 29, 2024

@Xampa5 Didn't know that, I'll fix that in a second.

@zGadli
Copy link
Contributor Author

zGadli commented Dec 30, 2024

@Xampa5 I brute-forced it. I'll code a better approach in my free time.

@dipu-bd dipu-bd merged commit 8d39e5a into dipu-bd:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants