Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical error page and improve db maxScore snake game logic #343

Merged
merged 4 commits into from
Mar 2, 2025

Conversation

carolinaisslaying
Copy link
Member

Description

This resolves an issue where the critical error page... wasn't working that well, as "del" was undefined, as well as the maxScore being set in the db to a more concise and appropriate database request.

Changes Summary

  • Snake game now uses mongodb's $inc to set a new maxScore in the db.
  • On the critical error page, ejs checks if del is defined first, and will omit the line that requires the use of del if it is undefined (that line is non-critical and just sets the release for sentry).

Type of Change

  • Feature enhancement
  • Bug fixes
  • Refactor
  • Breaking change
  • Performance improvement/reducing time complexity

Confirmation Checklist

  • I have ensured that my code follows the project's style guidelines (pnpm run pretty).
  • I have performed a self-review of my code and corrected any issues.
  • I have tested the changes to verify they work as intended.
  • I have confirmed that my changes do not introduce new security vulnerabilities.
  • I have documented and communicated any breaking changes appropriately.

@carolinaisslaying carolinaisslaying added the bug Issue/PR related to an error, fault, or flaw. label Mar 2, 2025
@carolinaisslaying carolinaisslaying added this to the 5.7.0 milestone Mar 2, 2025
@carolinaisslaying carolinaisslaying merged commit a6433d9 into main Mar 2, 2025
4 checks passed
@carolinaisslaying carolinaisslaying deleted the carolina-next branch March 2, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR related to an error, fault, or flaw.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant