Array access fix #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem with failed to fetch error when accessing arrays with an index with multiple digits.
Cause:
When reading the index of an array param, strtok_r is used to tokenize the string around the '[' character.
strtok_r then replaces the '[' with a '\0'. As this is done directly on the function input, this introduces an unexpected side-effect.
This is solved by copying the input and searching on the copy.
The problem does not occur on single digit due to the second bug where the index is supposed to be removed. Here we need to remove the number of digits and both the starting and ending bracket, thus
(index_length+2)