Add support for border-width shorthand property.
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,46 +27,46 @@ | |||
| logger = logging.getLogger(__name__) | |||
|
|
|||
|
|
|||
| def expand_shorthand_box_property(name, value): | |||
There was a problem hiding this comment.
Passing name here doesn't really make sense with the addition of templating, so I removed it. Not sure there would be other cases where property expansion relies on the original property name being passed in.
There was a problem hiding this comment.
It would probably be necessary to determine the syntax for those other, more complex properties but I think this interface is fine as it is.
| @@ -25,28 +25,30 @@ class TestCase(Exam, unittest.TestCase): | |||
|
|
|||
|
|
|||
| def test_expand_shorthand_box_property(): | |||
There was a problem hiding this comment.
Seeing a test for border-{}-box would have been nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to GH-20.
References GH-19.