-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using the kiosk on platforms without DBus #159
Conversation
@krksgbr Are you able to run the kiosk on macOS with these changes? |
06fe495
to
8511097
Compare
I tried to add a simple smoke test to verify that the kiosk can run on macOS, but there seems to be another error after the proxy/DBus issue is resolved. I am not sure whether this is due to something in the GitHub runner env, or an additional problem with running on macOS. This PR is blocked until a macOS user looks at it on their machine. |
Strangely, I can't build the nix-shell of the kiosk on macOS. I'm not sure what's different in my environment from GitHub's runner's, but it's already surprising that it matters. I tried different versions of nixpkgs: 24.05-pre, the 23.11-darwin branch, but they also didn't work. What's also strange is that attempting to build the shell produced two different errors for the same derivation on two different attempts. First run:
Second run:
I'll continue investigating. |
The same issue is reported here: According to one of the comments it's an aarch64-darwin specific problem. |
|
Executing another bash inside the shell hook seems to break running commands with `nix-shell --run`, something we assumed to work in the CI configuration. It seems that the Qt wrapper is already set up at least in modern Nixpkgs, so we can simply remove the code for spawning the wrapped bash.
We previously added support for using the kiosk without connman installed, but it still crashed when started on systems without DBus (i.e. any non-Linux platform). With this change we add a stub implementation of the core proxy abstraction, which is going to provide safe no-op responses on non-Linux platforms, allowing to use the kiosk, albeit without proxy support.
d7dc0e4
to
6e125e8
Compare
I rebased after #164 being merged, maybe this helps somehow. |
Unfortunately this didn't help as it's the webengine bindings that fail to build. |
@knuton I've amended your work here and created a separate shell for running the kiosk on macOS: knuton/playos@multi-platform-kiosk...krksgbr:playos:kiosk-on-macos This gets the job done until the upstream issues are fixed. How should we proceed? Should I push my changes to this PR or should I open a new one? |
Cool 👌 As your approach goes well beyond the goal of this PR, which only aimed to address the proxy issue, I think a new PR would make sense. |
We previously added support for using the kiosk without connman installed, but it still crashed when started on systems without DBus (i.e. any non-Linux platform).
With this change we add a stub implementation of the core proxy abstraction, which is going to provide safe no-op responses on non-Linux platforms, allowing to use the kiosk, albeit without proxy support.
Checklist