Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Qt 6 migration of kiosk browser #169

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Conversation

knuton
Copy link
Member

@knuton knuton commented Jun 28, 2024

The Qt 6 version of QtWebEngine brought too many sneaky breaking changes and is holding up this PlayOS release because of it.

Revert to unblock releasing the other features and component updates. Migration can be picked up without having to rush it.

Blocking issues

The last currently known blocking issue is broken session persistence with the Qt 6 kiosk, due to two reasons:

  1. Breaking change in Qt 6, default profile is now volatile and never persisted
  2. Change in wrapper setup kiosk/default.nix seems to have changed filepath at which the default profile is stored (.kiosk-browser-wrapped instead of kiosk-browser)

It is also currently unconfirmed whether the Qt 6 QtWebEngine is going to pick up the Qt 5 profile information, and if so, whether it is backwards compatible when booting back into Qt 5 afterwards.

Checklist

  • Changelog updated
  • Code documented
  • User manual updated

knuton added 5 commits June 28, 2024 16:45
This reverts commit 87c5782, reversing
changes made to 17dc536.
…r-reload"

This reverts commit 45b9d93, reversing
changes made to 17dc536.
…size"

This reverts commit 17dc536, reversing
changes made to 3a33b76.
…-refresh"

This reverts commit 3a33b76, reversing
changes made to 2d4542a.
This reverts commit 3d022a8, reversing
changes made to c43a319.
@knuton knuton changed the base branch from release/2024.5.x to main June 28, 2024 14:48
@knuton knuton marked this pull request as ready for review June 28, 2024 14:51
@knuton knuton added the reviewable Ready for initial or iterative review label Jun 28, 2024
@knuton knuton requested a review from guyonvarch June 28, 2024 14:51
Copy link
Member

@guyonvarch guyonvarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good:

  • looking at the last merges, the revert list fits,
  • I could run the VM and play a game,
  • I can refresh and hard refresh, and I can still tab to have the focus.

@guyonvarch guyonvarch merged commit a524d7a into dividat:main Jul 1, 2024
5 checks passed
@guyonvarch guyonvarch removed the reviewable Ready for initial or iterative review label Jul 1, 2024
@knuton knuton deleted the revert-qt6 branch July 1, 2024 08:11
@knuton
Copy link
Member Author

knuton commented Sep 26, 2024

Some links related to the profile issue:

knuton added a commit to knuton/playos that referenced this pull request Oct 17, 2024
This reverts commit a524d7a, reversing
changes made to 762787d.
@knuton knuton mentioned this pull request Oct 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants