-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Qt 6 migration of kiosk browser #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyonvarch
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good:
- looking at the last merges, the revert list fits,
- I could run the VM and play a game,
- I can refresh and hard refresh, and I can still tab to have the focus.
Some links related to the profile issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Qt 6 version of QtWebEngine brought too many sneaky breaking changes and is holding up this PlayOS release because of it.
Revert to unblock releasing the other features and component updates. Migration can be picked up without having to rush it.
Blocking issues
The last currently known blocking issue is broken session persistence with the Qt 6 kiosk, due to two reasons:
kiosk/default.nix
seems to have changed filepath at which the default profile is stored (.kiosk-browser-wrapped
instead ofkiosk-browser
)It is also currently unconfirmed whether the Qt 6 QtWebEngine is going to pick up the Qt 5 profile information, and if so, whether it is backwards compatible when booting back into Qt 5 afterwards.
Checklist