Patch ppx_protocol_conv_jsonm to not have a dependency on ppxlib #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the following commit upstream for a similar change to the json driver: andersfugmann/ppx_protocol_conv@1be9d66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the following commit upstream for a similar change to the (yo)json driver:
andersfugmann/ppx_protocol_conv@1be9d66
This avoids pulling in all of ppxlib (which is a good thing in general) and in particular does not pollute the global namespace with
compiler-libmodules (which fixes the issues I was having with rebasing #194 ontomain).Will submit a patch upstream as well.
Side-note: it might make be useful at some point to review the current dependencies in general, because e.g. we link to
Base, but the way it is used is redundant.