Cherry-picked CI additions

[yfyf]

Cherry-picked these from #184, because they are needed in general and because I want to use the common CI step abstraction in #200

[yfyf]

Whoops, pushed without testing. Amended and forced pushed, should be good now.

[guyonvarch]

Running testing/run works successfully on main, but on this branch, I get the following error:

client # [   26.006196] connmand[680]: Failed to find URL:http://ipv6.connman.net/online/status.html
…
client # [   37.041887] connmand[680]: Failed to find URL:http://ipv4.connman.net/online/status.html
…
[TestCase] kiosk-browser uses configured proxy... Fail!

Running testing/run, with everything commented except for manual tests, the script gets blocked:

run the VM test script
additionally exposed symbols:
    machine,
    vlan1,
    start_all, test_script, machines, vlans, driver, log, os, create_machine, subtest, run_tests, join_all, retry, serial_stdout_off, serial_stdout_on, polling_condition, Machine
machine: starting vm

Any idea?

[yfyf]

Running testing/run works successfully on main, but on this branch, I get the following error:

<..>
[TestCase] kiosk-browser uses configured proxy... Fail!

Can you retry nix-build -A driver testing/integration/kiosk-proxy.nix && ./result/bin/nixos-test-driver a few times? This test is flaky, I have had it fail locally on different branches, so I think this is unrelated. It passes for me, I cannot trigger the failure currently.

Running testing/run, with everything commented except for manual tests, the script gets blocked:
...
Any idea?

Hmmm, what operating system are you using? Might be something failing due to virtio-vga? Are you able to run ./build vm with the patch below?

diff --git a/testing/run-in-vm/run-in-vm.py b/testing/run-in-vm/run-in-vm.py
index 4f70333..b2a5d83 100755
--- a/testing/run-in-vm/run-in-vm.py
+++ b/testing/run-in-vm/run-in-vm.py
@@ -64,7 +64,8 @@ def run_vm(system, qemu_opts, kernel_arguments):
            '-initrd', initrd,
            '--virtfs', virtfs_opts,
            '-append', kernel_arguments,
-            '-vga', 'virtio', # Display screen as big as possible
+            #'-vga', 'virtio', # Display screen as big as possible
+            '-device', 'virtio-vga,max_outputs=2',
            # Unused shell. This is used by the "backdoor" in <nixos/modules/test-instrumentation.nix>.
            # TODO: Set up a Unix Socket from Python and connect to shell
            '-chardev', 'socket,id=shell,path={}/not-working-shell,server=on,wait=off'.format(backdoor_dir),

[guyonvarch]

Can you retry nix-build -A driver testing/integration/kiosk-proxy.nix && ./result/bin/nixos-test-driver a few times? This test is flaky, I have had it fail locally on different branches, so I think this is unrelated. It passes for me, I cannot trigger the failure currently.

I ran it 4 times, it passed 3, and failed once:

client # curl: (28) Failed to connect to theproxy port 8888 after 131731 ms: Couldn't connect to server
client: output: 
[TestPrecondition] Proxied curl request to kiosk URL arrives... Fail!

[guyonvarch]

Hmmm, what operating system are you using? Might be something failing due to virtio-vga? Are you able to run ./build vm with the patch below?

I am using NixOS. I can run ./build vm all right with the changes. I can’t run the VM once it’s build, maybe that’s normal given the modifications.

[guyonvarch]

I can not build and run the VM in main, so this has nothing to do with the changes here.

The error looks related to pipewire, to which I switched recently, but with the changes from #184, I can build and run the VM all right.

The code looks good, let’s move forward with it. 👌