Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release validation test finalizations #223

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

yfyf
Copy link
Collaborator

@yfyf yfyf commented Jan 9, 2025

Just some final cleanups and adding references to the two backported release disk images for 2023.9.1 and 2024.7.0.

Had to switch to HTTP for fetchurl due to nix bugs 🤷 and add minor OCR improvements to ensure more consistent detection.

Tested both base images with:

nix-build testing/release-validation.nix 

and

nix-build --arg baseSystemVersion '"2023.9.1-DISK"' testing/release-validation.nix 

Checklist

  • Changelog updated
  • Code documented
  • User manual updated

yfyf added 4 commits January 8, 2025 13:02
testing/release-validation.nix adds two large items to the nix store:
- the release disk image fetched (~4GiB)
- the built RAUC bundle (~2GiB)

We don't want to push that to the GH cache.
@yfyf yfyf added the reviewable Ready for initial or iterative review label Jan 9, 2025
@yfyf yfyf requested a review from guyonvarch January 9, 2025 09:33
@yfyf
Copy link
Collaborator Author

yfyf commented Jan 9, 2025

P.S. I sneaked a little workflow fix (f6b3289) for building the 2023.9.1-DISK release.

Copy link
Member

@guyonvarch guyonvarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, I also checked that I could run successfully the 2 upgrade tests.

@guyonvarch guyonvarch merged commit 3c0677a into dividat:main Jan 13, 2025
16 checks passed
@guyonvarch guyonvarch removed the reviewable Ready for initial or iterative review label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants