-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the Calmjs javascript minifier #957
Conversation
…onverting them into the new COMPRESS_FILTERS[css/js] form.
Hi, Sorry, but I think this doesn't merit inclusion in django-compressor core. You can use it in your own project if needed as it doesn't require anything special on compressor's side to do that. |
SlimIt hasn't seen a new release since 2013, which means right now, there are a number of problems with it. For example, pretty much every feature of ES6 is unsupported. Pull requests for these features have been waiting since as far back as 2013. Meanwhile Calmjs' last release was a few months ago, ES6 is partially supported, it can generate source maps, and it's slightly faster than SlimIt. If Django-Compressor is to provide a single js minifier out of the box, I don't think SlimIt is the right choice anymore IMO. We should keep it for backwards compatibility, but please consider adding a better option like Calmjs. |
Thanks for your reply, I appreciate it. I don't really like shipping too many filters by default, especially relatively trivial ones, but I you make a good point about slimit not cutting it any more. |
One thing I don't like about the slimit integration, and this one has the same problem, is that there isn't even a basic test covering it. Could you add the latest |
…the Calmjs minifier.
Thanks! It bothered me too, so I added tests for both SlimIT and Calmjs. |
Thank you for your contribution! I'll do a release eventually later this month, in the meantime it'll be available on the develop branch. |
Great, thanks! |
Calmjs is a javascript minifier similar to SlimIt that has some advantages. https://github.com/calmjs/calmjs.parse
For me, it solves the following problem:
rspivak/slimit#97