liquidation-crud-test #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, sync with main branch @shamoo53 |
|
@shamoo53 fix please also pylint issue |
|
I will do that now |
|
Hi @djeck1432 fixed pylint issue |
djeck1432
requested changes
Feb 24, 2025
margin_app/app/tests/liquidation.py
Outdated
| def commit(self): | ||
| pass | ||
|
|
||
| def query(self, model): |
There was a problem hiding this comment.
why do you need it? if you don't call it?
|
The commit method is required to simulate the transaction interface. Even though it performs no operation in tests, it allows our code to call commit() without errors, ensuring that our test environment mirrors the production interface where commit would actually execute a transaction commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crud test completed