feat: [MarginFrontend] Home page #634
Merged
+606
−663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restructured App.tsx to use a new Home route - Added custom font imports for InstrumentSans, BricolageGrotesque, and PilotCommandSpaced - Created core Button component with variant support using class-variance-authority - Implemented Header and Footer components with responsive design - Added initial home page content with typography and button styling
whateverfw
requested changes
Feb 24, 2025
- Standardize CSS variable naming convention (e.g., --color-*, --font-*, --text-*) - Update component class names to use new CSS variables - Simplify and normalize font and color references across components - Remove hardcoded color and font values in favor of theme variables
whateverfw
requested changes
Feb 24, 2025
- Update CSS variables with more descriptive color names - Modify Header, Footer, and Home components
whateverfw
requested changes
Feb 24, 2025
Comment on lines
3
to
15
| icon: "src/assets/images/DiscordLogo.png", | ||
| link: "https://discord.com/", | ||
| title: "Discord", | ||
| }, | ||
| { | ||
| icon: "src/assets/images/XLogo.png", | ||
| link: "https://twitter.com/SpotNet_123", | ||
| title: "X", | ||
| }, | ||
| { | ||
| icon: "src/assets/images/TelegramLogo.png", | ||
| link: "https://t.me/djeck_vorobey1", | ||
| title: "Telegram", |
There was a problem hiding this comment.
I don't see these images, am I missing something>?
There was a problem hiding this comment.
@whateverfw , on my local, its working, trying to replicate your issue though
There was a problem hiding this comment.
do you have images folder inside src/assets locally?
Because if you check PR and commits - there are only fonts, not images
There was a problem hiding this comment.
yes i do, i'll change name to something else
There was a problem hiding this comment.
are you sure those pushed to git correctly?
- Add Playwright for browser testing - Integrate Tailwind CSS in Vite configuration - Update Button and Header components with refined styling - Add social media logo assets - Refactor file paths and button variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor frontend: Add base layout, fonts, and core UI components