Optimized bash scripts

[jamallorock]

Description

In common_utils.sh script:
Key Improvements

✅ Uses kubectl wait instead of an inefficient polling loop with sleep.
✅ Removes redundant kubectl get pods calls, reducing API requests.
✅ Adds set -e to exit immediately on failure, improving script safety.
✅ Uses standard exit codes (1 instead of -1) for better compatibility.
✅ Uses local for variables to avoid polluting the global namespace.

In generate-certs.sh script:
The improvements include:
✅ Better error handling – added error messages.
✅ Variability and flexibility – option to change parameters without editing the code.
✅ Consistency and readability – structured code with clear messages.

Motivation and Context

Closes #

Screenshots (if appropriate):

How Has This Been Tested?

Tested localy.

Checklist:

• I have updated the documentation accordingly.
• I have updated the tests accordingly.
• I have run make generate and checked in the results.
• I have run make manifests and checked in the results.

For new code releases:

• I have bumped the appVersion in the Helm chart.

For new Helm chart releases:

• I have bumped the Helm chart version.

[aw1cks]

Suggested change

	# 📍 Setting default values for CA certificate
	COUNTRY="US"
	STATE="YourState"
	CITY="YourCity"
	ORG="YourOrganization"
	ORG_UNIT="YourOrganizationalUnit"
	COMMON_NAME="adcs-issuer Test CA"
	KEY_SIZE=4096
	DAYS_VALID=3650 # 10 years
	# 📍 Setting default values for CA certificate
	COUNTRY='US'
	STATE='YourState'
	CITY='YourCity'
	ORG='YourOrganization'
	ORG_UNIT='YourOrganizationalUnit'
	COMMON_NAME='adcs-issuer Test CA'
	KEY_SIZE='4096'
	DAYS_VALID='3650' # 10 years

[jamallorock]

suggests using doubles everywhere. @djkormo

[aw1cks]

Suggested change

	echo "🔧 Creating directories..."
	echo '🔧 Creating directories...'

[jamallorock]

Change without impact. Doesn't understand why it changed to single.

[aw1cks]

Suggested change

	echo "📂 Copying certificates..."
	echo '📂 Copying certificates...'

[jamallorock]

Change without impact. Doesn't understand why it changed to single,

[aw1cks]

Suggested change

	echo "✅ Certificates successfully generated!"
	echo '✅ Certificates successfully generated!'

[jamallorock]

Change without impact. Doesn't understand why it changed to single.