Skip to content
This repository has been archived by the owner on Feb 21, 2018. It is now read-only.

Add an explicit attribute collapsing specialization for two unused_types #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jktjkt
Copy link
Contributor

@jktjkt jktjkt commented Oct 20, 2013

The test case is trying to ignore the attribute of the CRLF rule. Without the
patch to make_attribute.hpp, the compiler doesn't know which of the
specializations to use, and the build fails.

@K-ballo
Copy link
Collaborator

K-ballo commented Oct 20, 2013

Could you please reduce the test case to the bare minimum? For instance, you don't need a grammar, a single rule should suffice. Additionally, please make your identifiers all lowercase.

The test case is trying to ignore the attribute of the CRLF rule. Without the
patch to make_attribute.hpp, the compiler doesn't know which of the
specializations to use, and the build fails.
@K-ballo
Copy link
Collaborator

K-ballo commented Oct 26, 2013

I was able to reduce the test case to a minimum:

unused_type attr;
rule<class rule_id> const r;
BOOST_TEST((test_attr("x", r = lit('x'), attr, true)));

Note that it belongs in rule* and not in sequence.

@djowel
Copy link
Owner

djowel commented Mar 18, 2014

I just migrated X3 to the boost repository. Please have your pull request there. This repo is going away. (https://github.com/boostorg/spirit/tree/develop)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants