-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python 3.13 support (+ minor docstring improvements) #133
Draft
eneelo
wants to merge
7
commits into
master
Choose a base branch
from
add-python313-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tovop No haste in getting this PR through. We will do it when time allows. |
An intense work week but I will attempt a review on Friday. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included in this PR
The documentation now states how to find information about supported python versions, without stating specifically which versions these are. This is to avoid the need to update this information several places when python version support changes.
qats.signal
,qats.fatigue.rainflow
andqats.stats
.Edit, 08.01.2025:
pyside6
(version 6.8.1.1) breaks installation, because poetry cannot find an installation candidate forshiboken6
version 6.8.1.1 (andpyside6
andshiboken6
version must be identical, ref. https://doc.qt.io/qtforpython-6/shiboken6/gettingstarted.html. A temporary fix is to requirepyside6 <= 6.8.1
inpyproject.toml
, thereby avoiding version 6.8.1.1. A looser dependency, allowing for>=6.8.1
, may be specified when this issue has been fixed on the pyside/shiboken side. This fixes Broken dependency for python 3.12 #134.Note:
shiboken6 6.6.x
(and thereforepyside6 6.6.x
) doesn't seem to work well withnumpy 2.x
, so it is desirable to allow forshiboken6 6.8.x
also forpython <=3.12
instead of restricting thenumpy
version more than needed.To be discussed:
Edit (08.01.2025):
poetry
version 2.0 (latest) requires python 3.9+, causing failed tests for python 3.8 (see https://github.com/dnvgl/qats/actions/runs/12666602368/job/35298567574?pr=133). Options: 1) drop support for python 3.8, or 2) ensure intest.yaml
thatpoetry 1.8
is installed for the python 3.8 tests (not sure if possible), or 3) specifypoetry 1.8.5
intest.yaml
(ref. https://github.com/snok/install-poetry).Currently in favor of option 1 (drop python 3.8 support).
Notes
pyproject.toml
: the dependencies undertool.poetry.dependencies
have been updated to work across python versions 3.8 through 3.13. It is probably possible (and certainly desirable) to clean up and simplify the dependency spec, which currently includes quite a few statements like "this version for python <= 3.12, that version for python 3.13", etc. At this stage, however, the main goal has been to ensure thatpoetry install
works across the supported python versions (and of course, thatpytest
andqats app
may thereafter be successfully executed).