Switch to git diff --exit-code
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be interesting to improve this to configure `diffoscope` as a "difftool" so we can get even more useful diffs if the binaries ever change as a result, but this is at least better than the prior state (as this will give us a diff of any text files in our failing CI).
yosifkit
approved these changes
Jan 21, 2025
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 21, 2025
Changes: - docker-library/hello-world@6ad8af5: Merge pull request docker-library/hello-world#121 from infosiftr/win2025 - docker-library/hello-world@2cd5514: Merge pull request docker-library/hello-world#119 from infosiftr/bump - docker-library/hello-world@0b8aa18: Merge pull request docker-library/hello-world#120 from infosiftr/git-diff--exit-code - docker-library/hello-world@a71acd2: Update to Bookworm + musl 1.2.5 - docker-library/hello-world@08987c7: Add Windows (Nano) Server 2025 variants - docker-library/hello-world@0e95907: Switch to `git diff --exit-code` - docker-library/hello-world@680f908: Update README - docker-library/hello-world@1f9e879: Update to actions/checkout@v4 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be interesting to improve this to configure
diffoscopeas a "difftool" so we can get even more useful diffs if the binaries ever change as a result, but this is at least better than the prior state (as this will give us a diff of any text files in our failing CI).