DCKM-435: remove optional attributes from pex proof requests #238
Conversation
| }, | ||
| { | ||
| path: ['$.expirationDate'], | ||
| optional: true, | ||
| optional: false, |
There was a problem hiding this comment.
should we have tests with both scenarios? Also, do we have tests that ensure the field isn't returned in the presentation if it's optional and the user deselects it?
There was a problem hiding this comment.
I've added better tests and also documentation about this function. For now, the optional attribute is used to reveal the attribute automatically and the user can't deselect it since there is no UI implication. For example, in the expiration date. But I can see potential issues with an attribute from the credential subject being marked as optional, since it will be always revealed and the user can't see that. I've just created a jira for it https://dock-team.atlassian.net/browse/DCKA-2504
Two scenarios I can think about:
-
Expiration date being shared automatically:
The user can't see that it will be shared -
Credential subject attributes being shared automatically
The user can't override that
We can handle that in the DCKM-439
| * @sphereon/pex is not able to handle optional attributes in the presentation definition | ||
| * Any optional attribute in the presentation definition will cause the library to throw an error | ||
| * This function removes the optional attribute from the presentation definition | ||
| * This is a temporary workaround until the issue is fixed in the @sphereon/pex library |
There was a problem hiding this comment.
is there an issue in that repository we can link to/track?
There was a problem hiding this comment.
I've created an issue for that Sphereon-Opensource/PEX#150
maycon-mello
deleted the
DCKM-435-wallet-679-expiry-date-when-present-in-vc-is-not-supported-in-the-wallet
branch
No description provided.