Fix PHPStan findings about iterable parameters

phpstan-baseline.neon

@@ -255,11 +255,6 @@ parameters:
 			count: 3
 			path: src/Sluggable/Handler/TreeSlugHandler.php
 
-		-
-			message: "#^Part \\$option \\(array\\{string, mixed\\}\\) of encapsed string cannot be cast to string\\.$#"
-			count: 1
-			path: src/Sluggable/Mapping/Driver/Annotation.php
-
 		-
 			message: "#^Access to an undefined property Doctrine\\\\Persistence\\\\Mapping\\\\ClassMetadata\\:\\:\\$isMappedSuperclass\\.$#"
 			count: 1
@@ -505,6 +500,11 @@ parameters:
 			count: 1
 			path: src/Tree/TreeListener.php
 
+		-
+			message: "#^Method Gedmo\\\\Uploadable\\\\Event\\\\UploadableBaseEventArgs\\:\\:__construct\\(\\) has parameter \\$config with no value type specified in iterable type array\\.$#"
+			count: 2
+			path: src/Uploadable/Event/UploadableBaseEventArgs.php
+
 		-
 			message: "#^Method Gedmo\\\\Uploadable\\\\Event\\\\UploadableBaseEventArgs\\:\\:getExtensionConfiguration\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 2

phpstan.neon.dist

@@ -19,8 +19,6 @@ parameters:
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is never written, only read\.$#'
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is never read, only written\.$#'
         - '#^Property Gedmo\\Tests\\.+\\Fixture\\[^:]+::\$\w+ is unused\.$#'
-        # @todo: Remove the following ignored error when the parameters are correctly declared.
-        - '#^Method Gedmo\\[^:]+::[^\(]+\(\) has parameter \$\w+ with no value type specified in iterable type array\.$#'
 
 rules:
     - PHPStan\Rules\Constants\MissingClassConstantTypehintRule

src/Loggable/Document/Repository/LogEntryRepository.php

@@ -106,7 +106,8 @@ public function revert($document, $version = 1)
     /**
      * Fills a documents versioned fields with data
      *
-     * @param object $document
+     * @param object               $document
+     * @param array<string, mixed> $data
      *
      * @return void
      *

src/Loggable/Mapping/Driver/Annotation.php

@@ -108,6 +108,8 @@ protected function isMappingValid(ClassMetadata $meta, $field)
     }
 
     /**
+     * @param array<string, mixed> $config
+     *
      * @return bool
      */
     protected function isClassAnnotationInValid(ClassMetadata $meta, array &$config)
@@ -117,6 +119,8 @@ protected function isClassAnnotationInValid(ClassMetadata $meta, array &$config)
 
     /**
      * Searches properties of embedded object for versioned fields
+     *
+     * @param array<string, mixed> $config
      */
     private function inspectEmbeddedForVersioned(string $field, array &$config, \Doctrine\ORM\Mapping\ClassMetadata $meta): void
     {

src/Loggable/Mapping/Driver/Xml.php

@@ -86,6 +86,8 @@ public function readExtendedMetadata($meta, array &$config)
 
     /**
      * Searches mappings on element for versioned fields
+     *
+     * @param array<string, mixed> $config
      */
     private function inspectElementForVersioned(\SimpleXMLElement $element, array &$config, ClassMetadata $meta): void
     {

src/Loggable/Mapping/Driver/Yaml.php

@@ -139,6 +139,10 @@ protected function _loadMappingFile($file)
         return \Symfony\Component\Yaml\Yaml::parse(file_get_contents($file));
     }
 
+    /**
+     * @param array<string, array<string, array<string, mixed>>> $mapping
+     * @param array<string, mixed>                               $config
+     */
     private function inspectEmbeddedForVersioned(string $field, array $mapping, array &$config): void
     {
         if (isset($mapping['fields'])) {

src/Mapping/Annotation/Blameable.php

@@ -34,6 +34,7 @@ final class Blameable implements GedmoAnnotation
     public $value;
 
     /**
+     * @param array<string, mixed> $data
      * @param string|string[]|null $field
      * @param mixed                $value
      */

src/Mapping/Annotation/IpTraceable.php

@@ -34,6 +34,7 @@ final class IpTraceable implements GedmoAnnotation
     public $value;
 
     /**
+     * @param array<string, mixed> $data
      * @param string|string[]|null $field
      * @param mixed                $value
      */

src/Mapping/Annotation/Loggable.php

@@ -37,6 +37,8 @@ final class Loggable implements GedmoAnnotation
     public $logEntryClass;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param class-string<T>|null $logEntryClass
      */
     public function __construct(array $data = [], ?string $logEntryClass = null)

src/Mapping/Annotation/Reference.php

@@ -51,6 +51,8 @@ abstract class Reference implements GedmoAnnotation
     public $inversedBy;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param class-string|null $class
      */
     public function __construct(

src/Mapping/Annotation/ReferenceIntegrity.php

@@ -30,7 +30,7 @@ final class ReferenceIntegrity implements GedmoAnnotation
     public $value;
 
     /**
-     * @param string|array|null $data
+     * @param string|array<string, mixed>|null $data
      */
     public function __construct($data = [], ?string $value = null)
     {

src/Mapping/Annotation/Slug.php

@@ -52,8 +52,9 @@ final class Slug implements GedmoAnnotation
     public $dateFormat = 'Y-m-d-H:i';
 
     /**
-     * @param string[]      $fields
-     * @param SlugHandler[] $handlers
+     * @param array<string, mixed> $data
+     * @param string[]             $fields
+     * @param SlugHandler[]        $handlers
      */
     public function __construct(
         array $data = [],

src/Mapping/Annotation/SlugHandler.php

@@ -33,12 +33,15 @@ final class SlugHandler implements GedmoAnnotation
     public $class = '';
 
     /**
-     * @var array<SlugHandlerOption>|array<array{string, mixed}>
+     * @var array<SlugHandlerOption>|array<string, mixed>
      */
     public $options = [];
 
     /**
-     * @phpstan-param string|class-string<SlugHandlerInterface> $class
+     * @param array<string, mixed> $data
+     *
+     * @phpstan-param string|class-string<SlugHandlerInterface>     $class
+     * @phpstan-param array<SlugHandlerOption>|array<string, mixed> $options
      */
     public function __construct(
         array $data = [],

src/Mapping/Annotation/SlugHandlerOption.php

@@ -35,7 +35,8 @@ final class SlugHandlerOption implements GedmoAnnotation
     public $value;
 
     /**
-     * @param mixed $value
+     * @param array<string, mixed> $data
+     * @param mixed                $value
      */
     public function __construct(
         array $data = [],

src/Mapping/Annotation/SoftDeleteable.php

@@ -35,6 +35,9 @@ final class SoftDeleteable implements GedmoAnnotation
     /** @var bool */
     public $hardDelete = true;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(array $data = [], string $fieldName = 'deletedAt', bool $timeAware = false, bool $hardDelete = true)
     {
         if ([] !== $data) {

src/Mapping/Annotation/Timestampable.php

@@ -34,8 +34,9 @@ final class Timestampable implements GedmoAnnotation
     public $value;
 
     /**
-     * @param string|string[] $field
-     * @param mixed           $value
+     * @param array<string, mixed> $data
+     * @param string|string[]      $field
+     * @param mixed                $value
      */
     public function __construct(array $data = [], string $on = 'update', $field = null, $value = null)
     {

src/Mapping/Annotation/Translatable.php

@@ -29,6 +29,9 @@ final class Translatable implements GedmoAnnotation
     /** @var bool|null */
     public $fallback;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(array $data = [], ?bool $fallback = null)
     {
         if ([] !== $data) {

src/Mapping/Annotation/TranslationEntity.php

@@ -33,6 +33,9 @@ final class TranslationEntity implements GedmoAnnotation
      */
     public $class;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(array $data = [], string $class = '')
     {
         if ([] !== $data) {

src/Mapping/Annotation/Tree.php

@@ -49,6 +49,8 @@ final class Tree implements GedmoAnnotation
     public $identifierMethod;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param 'closure'|'materializedPath'|'nested'|null $type
      */
     public function __construct(

src/Mapping/Annotation/TreeClosure.php

@@ -34,6 +34,8 @@ final class TreeClosure implements GedmoAnnotation
     public $class;
 
     /**
+     * @param array<string, mixed> $data
+     *
      * @phpstan-param string|class-string<AbstractClosure> $class
      */
     public function __construct(array $data = [], string $class = '')

src/Mapping/Annotation/TreeLevel.php

@@ -33,6 +33,9 @@ final class TreeLevel implements GedmoAnnotation
      */
     public $base = 0;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(
         array $data = [],
         int $base = 0

src/Mapping/Annotation/TreePath.php

@@ -40,6 +40,9 @@ final class TreePath implements GedmoAnnotation
     /** @var bool */
     public $endsWithSeparator = true;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(
         array $data = [],
         string $separator = ',',

src/Mapping/Annotation/TreeRoot.php

@@ -29,6 +29,9 @@ final class TreeRoot implements GedmoAnnotation
     /** @var string|null */
     public $identifierMethod;
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(array $data = [], ?string $identifierMethod = null)
     {
         if ([] !== $data) {

src/Mapping/Annotation/Uploadable.php

@@ -76,6 +76,9 @@ final class Uploadable implements GedmoAnnotation
      */
     public $disallowedTypes = '';
 
+    /**
+     * @param array<string, mixed> $data
+     */
     public function __construct(
         array $data = [],
         bool $allowOverwrite = false,

src/Mapping/Driver.php

@@ -26,12 +26,14 @@ interface Driver
     /**
      * Read the extended metadata configuration for a single mapped class.
      *
-     * @param ClassMetadata&(OdmClassMetadata|OrmClassMetadata) $meta
+     * @param ClassMetadata        $meta
      * @param array<string, mixed> $config
      *
      * @return void
      *
      * @throws InvalidMappingException if the mapping configuration is invalid
+     *
+     * @phpstan-param ClassMetadata&(OdmClassMetadata|OrmClassMetadata) $meta
      */
     public function readExtendedMetadata($meta, array &$config);
 

src/Mapping/Event/AdapterInterface.php

@@ -31,8 +31,8 @@ interface AdapterInterface
      *
      * Calls a method on the event args object.
      *
-     * @param string $method
-     * @param array  $args
+     * @param string            $method
+     * @param array<int, mixed> $args
      *
      * @return mixed
      */

src/Mapping/ExtensionMetadataFactory.php

@@ -225,6 +225,9 @@ protected function getDriver($omDriver)
         return $driver;
     }
 
+    /**
+     * @param array<string, mixed> $config
+     */
     private function storeConfiguration(string $className, array $config): void
     {
         if (null === $this->cacheItemPool) {

src/References/Mapping/Event/ReferencesAdapter.php

@@ -35,9 +35,9 @@ public function getIdentifier($om, $object, $single = true);
     /**
      * Gets a single reference from the provided object manager for a class and identifier.
      *
-     * @param ObjectManager    $om
-     * @param string           $class
-     * @param array|string|int $identifier
+     * @param ObjectManager                       $om
+     * @param string                              $class
+     * @param array<int|string, mixed>|string|int $identifier
      *
      * @phpstan-param class-string $class
      *

src/Sluggable/Handler/SlugHandlerInterface.php

@@ -32,9 +32,10 @@ public function __construct(SluggableListener $sluggable);
      * Hook on slug handlers before the decision is made whether
      * the slug needs to be recalculated.
      *
-     * @param object $object
-     * @param string $slug
-     * @param bool   $needToChangeSlug
+     * @param array<string, mixed> $config
+     * @param object               $object
+     * @param string               $slug
+     * @param bool                 $needToChangeSlug
      *
      * @return void
      */
@@ -43,8 +44,9 @@ public function onChangeDecision(SluggableAdapter $ea, array &$config, $object,
     /**
      * Hook on slug handlers called after the slug is built.
      *
-     * @param object $object
-     * @param string $slug
+     * @param array<string, mixed> $config
+     * @param object               $object
+     * @param string               $slug
      *
      * @return void
      */
@@ -53,8 +55,9 @@ public function postSlugBuild(SluggableAdapter $ea, array &$config, $object, &$s
     /**
      * Hook for slug handlers called after the slug is completed.
      *
-     * @param object $object
-     * @param string $slug
+     * @param array<string, mixed> $config
+     * @param object               $object
+     * @param string               $slug
      *
      * @return void
      */
@@ -68,6 +71,8 @@ public function handlesUrlization();
     /**
      * Validates the options for the handler.
      *
+     * @param array<string, mixed> $options
+     *
      * @throws InvalidMappingException if the configuration is invalid
      *
      * @return void

src/Sluggable/Handler/SlugHandlerWithUniqueCallbackInterface.php

@@ -23,8 +23,9 @@ interface SlugHandlerWithUniqueCallbackInterface extends SlugHandlerInterface
     /**
      * Hook for slug handlers called before it is made unique.
      *
-     * @param object $object
-     * @param string $slug
+     * @param array<string, mixed> $config
+     * @param object               $object
+     * @param string               $slug
      *
      * @return void
      */

src/Sluggable/Mapping/Driver/Annotation.php

@@ -126,6 +126,8 @@ protected function getSlugHandlers(\ReflectionProperty $property, Slug $slug, Cl
     }
 
     /**
+     * @param array<string, mixed> $config
+     *
      * @return array<string, array<string, mixed>>
      */
     private function retrieveSlug(ClassMetadata $meta, array &$config, \ReflectionProperty $property, ?string $fieldNamePrefix = null): array

src/Sluggable/Mapping/Driver/Xml.php

@@ -77,6 +77,9 @@ protected function isValidField($meta, $field)
         return $mapping && in_array($mapping['type'], self::VALID_TYPES, true);
     }
 
+    /**
+     * @param array<string, mixed> $config
+     */
     private function buildFieldConfiguration(ClassMetadata $meta, string $field, \SimpleXMLElement $mapping, array &$config): void
     {
         /**