Merge pull request #1768 from vetalt/shouldHandleOnlyZeroInSlug

nullable slug must not be null if base field has "0"
doctrine-extensions · Mar 22, 2017 · fe152e1 · fe152e1
2 parents c186806 + ca395ba
commit fe152e1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/Gedmo/Sluggable/SluggableListener.php b/lib/Gedmo/Sluggable/SluggableListener.php
@@ -381,7 +381,7 @@ private function generateSlug(SluggableAdapter $ea, $object)
                     $slug = substr($slug, 0, $mapping['length']);
                 }
 
-                if (isset($mapping['nullable']) && $mapping['nullable'] && !$slug) {
+                if (isset($mapping['nullable']) && $mapping['nullable'] && strlen($slug) === 0) {
                     $slug = null;
                 }
 

diff --git a/tests/Gedmo/Sluggable/Issue/Issue131Test.php b/tests/Gedmo/Sluggable/Issue/Issue131Test.php
@@ -46,6 +46,20 @@ public function testSlugGeneration()
         $this->assertNull($test2->getSlug());
     }
 
+    /**
+     * @test
+     */
+    public function shouldHandleOnlyZeroInSlug()
+    {
+        $article = new Article();
+        $article->setTitle('0');
+
+        $this->em->persist($article);
+        $this->em->flush();
+
+        $this->assertEquals('0', $article->getSlug());
+    }
+
     protected function getUsedEntityFixtures()
     {
         return array(