Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHPUnit config to restore Codecov support #2842

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jul 17, 2024

After #2818 it looks like Codecov hasn't been working because the coverage config was looking for the wrong source path. That's been fixed. A couple other minor QoL improvements:

  • Updates .gitignore to ignore a phpunit.xml at root instead of inside the tests folder, making local edits easier (don't have to add the -c tests/phpunit.xml config anymore to not use the dist file)
  • Adds the code coverage to .gitignore (generally won't be there, but doesn't hurt since I copied the command out of the GHA config to make sure it actually generated a coverage file)
  • Updates the PHPUnit config to use the XSD from the local install instead of a URL, as this regularly falls out-of-date

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.84%. Comparing base (0632ab1) to head (63fa9bd).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2842      +/-   ##
==========================================
+ Coverage   78.75%   78.84%   +0.09%     
==========================================
  Files         163      167       +4     
  Lines        8593     8638      +45     
==========================================
+ Hits         6767     6811      +44     
- Misses       1826     1827       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phansys phansys merged commit ddbbd27 into doctrine-extensions:main Jul 24, 2024
22 checks passed
@phansys
Copy link
Collaborator

phansys commented Jul 24, 2024

Thank you @mbabker!

@mbabker mbabker deleted the phpunit-conf-fixes branch July 25, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants