Use LazyGhostObject for proxy objects #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
use-lazy-ghost
branch
from
77c57f1 to
6d1cacd
Compare
GromNaN
commented
Jan 22, 2025
|
LGTM in general. Do we want to give people the opportunity to disable lazy ghost objects in the config (and default to |
GromNaN
force-pushed
the
use-lazy-ghost
branch
from
3a16ec8 to
cd20e33
Compare
|
I added a configuration that is true when the feature is available, and reverted the need to update minimal version of |
GromNaN
force-pushed
the
use-lazy-ghost
branch
from
6ade0ee to
adba204
Compare
GromNaN
commented
Jan 23, 2025
| @@ -39,6 +40,13 @@ public function getConfigTreeBuilder(): TreeBuilder | |||
| ->children() | |||
| ->scalarNode('proxy_namespace')->defaultValue('MongoDBODMProxies')->end() | |||
| ->scalarNode('proxy_dir')->defaultValue('%kernel.cache_dir%/doctrine/odm/mongodb/Proxies')->end() | |||
| ->booleanNode('enable_lazy_ghost_objects') | |||
There was a problem hiding this comment.
alcaeus
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the release of
doctrine/mongodb-odm: 2.10with LazyGhostObject support provided bysymfony/var-exporter:Enable
UseLazyGhostObjectconfiguration and fix proxy interface after the default configuration is reset to Proxy Manager by doctrine/mongodb-odm#2720 for compatibility with older versions of the bundle.New configuration setting:
enable_lazy_ghost_objectswhich is true by default when the feature is available.