Fix for DC-797, 1-to-1 (or-none) hydrated dirty

Don't consider a change from null to Doctrine_Null to be a value modification
doctrine · Sep 17, 2010 · 93f01b7 · 93f01b7 · jwage · Dec 8, 2010
1 parent 1ccee08
commit 93f01b7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/lib/Doctrine/Record.php b/lib/Doctrine/Record.php
@@ -1537,6 +1537,10 @@ protected function _isValueModified($type, $old, $new)
             return true;
         }
 
+        if (($old === null || $old instanceof Doctrine_Null) && ($new == null || $new instanceof Doctrine_Null)) {
+            return false;
+        }
+
         if ($type == 'boolean' && (is_bool($old) || is_numeric($old)) && (is_bool($new) || is_numeric($new)) && $old == $new) {
             return false;
         } else if (in_array($type, array('decimal', 'float')) && is_numeric($old) && is_numeric($new)) {