Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dtk-template & add CI #4

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Update dtk-template & add CI #4

merged 2 commits into from
Dec 27, 2024

Conversation

encounter
Copy link
Contributor

@encounter encounter commented Dec 26, 2024

This brings the repo up to date with dtk-template, and adds a CI workflow.

Notably:

  • The orig/RSBE01 dir has been renamed to RSBE01_02. Devs will have to move their files to the new location. Directory structure is created for all other Brawl versions, even though no configuration exists for them yet.
  • HomeBtnIcon was converted to use dtk's extract feature (see config/RSBE01_02/config.yml)
  • VS Code configuration was added to use clangd, which is more accurate than IntelliSense, but it will complain about invalid syntax in source files that use MWCC-specific features. These can be fixed incrementally by wrapping them in macros. For example, __declspec(section ".init") could be replaced with something like:
    #ifdef __MWERKS__
    #define DECL_SECTION(name) __declspec(section name)
    #else
    #define DECL_SECTION(name)
    #endif
  • Enhanced CLI progress reporting via objdiff-cli. This now shows "Matched %" as the primary metric, which includes matching functions in unlinked/NonMatching files, instead of only counting linked files.
  • Updated README.md to have complete setup instructions.

@encounter encounter merged commit 3484c07 into main Dec 27, 2024
2 checks passed
@encounter encounter deleted the update-dtk-template branch December 27, 2024 04:58
Copy link
Collaborator

@mparisi20 mparisi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants