Migrate to stable strict provenance APIs and elide some redundant lifetimes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR essentially does a Clippy pass over the code with Clippy from Rust 1.84.1. However, this includes the
sptrimports now being marked as redundant because the provided polyfill trait for the strict provenance APIs is no longer used now that strict provenance including all functions used bycstreewas stabilized instd/corein Rust 1.84.I've decided to go ahead and make the swap, which will raise
cstree's MSRV to 1.84. This is of course very recent, but should less aggressive whenever the next version ofcstreeis actually released, which I presume to be past Feb. 20th, the release date of Rust 1.85 and the 2024 edition.Aside from that, the changes are mostly eliding some lifetimes which the compiler can figure out by itself.