Skip to content

Commit

Permalink
Merge pull request #43 from donhector/hector2
Browse files Browse the repository at this point in the history
hector2
  • Loading branch information
donhector authored Dec 3, 2021
2 parents 762a79b + d2173b9 commit 6f196df
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .releaserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ plugins:
- BREAKING

# Generate us a changelog file
- - "@semantic-release/changelog"
- changelogFile: CHANGELOG.md
# - - "@semantic-release/changelog"
# - changelogFile: CHANGELOG.md

# Commit the generated changelog file into our git repo.
# Since we are enforcing conventional commmits in our project,
Expand All @@ -112,10 +112,10 @@ plugins:
# so our release workflow logic can easily filter out / ignore these kind of commits.
# In fact, since recently, Github workflows knows how to handle this logic automatically
# See (https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/)
- - "@semantic-release/git"
- assets:
- CHANGELOG.md
message: "chore(release): update changelog to ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
# - - "@semantic-release/git"
# - assets:
# - CHANGELOG.md
# message: "chore(release): update changelog to ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"

# Create a release in Github
- - "@semantic-release/github"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,10 @@ Author Information
[commitizen-badge]: https://img.shields.io/badge/commitizen-friendly-brightgreen.svg
[commitizen-link]: http://commitizen.github.io/cz-cli

TODO
<!-- TODO
------------
Research hook execution order: We want commitizen to run prior to molecule test
Investigate why there was no release even with `fix:` commits
- Looks like squash merging a PR, creates a commit with the name of the PR
so if the PR is not named conventiaolly, semantic-release will ignore it for comuputing the release
Research semantic pull-requests, so PR titles follow conventional commits spec
Research semantic pull-requests, so PR titles follow conventional commits spec -->

0 comments on commit 6f196df

Please sign in to comment.