Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up --formats and --slots inputs for texture compression #1150

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Clean up --formats and --slots inputs for texture compression #1150

merged 3 commits into from
Oct 31, 2023

Conversation

donmccurdy
Copy link
Owner

Fixes a typo when using the CLI optimize command for KTX2 compression. Extends non-GPU texture compression commands to support WebP and AVIF as input formats. Simplifies syntax:

# before
gltf-transform webp in.glb out.glb --formats "image/png" --lossless

# after
gltf-transform webp in.glb out.glb --formats "png" --lossless

@donmccurdy donmccurdy added bug Something isn't working package:cli labels Oct 30, 2023
@donmccurdy donmccurdy added this to the v3.8 milestone Oct 30, 2023
@donmccurdy donmccurdy merged commit 4fd74bf into main Oct 31, 2023
@donmccurdy donmccurdy deleted the fix/cli-texture-compress-formats branch October 31, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:cli
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
1 participant
@donmccurdy