Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Production => main #4878

Closed
wants to merge 7 commits into from
Closed

Merge Production => main #4878

wants to merge 7 commits into from

Conversation

davfost
Copy link
Contributor

@davfost davfost commented Feb 1, 2025

Main build: https://dnceng.visualstudio.com/internal/_build/results?buildId=2625115&view=results
Rollout issue: #4839

NOTE: There is an unexpected change in this PR but it looks like the merge from production to main has not been done in a while.

@davfost davfost self-assigned this Feb 1, 2025
@@ -124,12 +124,6 @@
"Branches": [ "main" ],
"IssuesId": "dotnet-dnceng-first-responder"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. We don't want to delete this in main, and we want this to be in production during the next deployment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will abandon this PR since this is an expected and unwanted change.

@davfost
Copy link
Contributor Author

davfost commented Feb 3, 2025

Abandoning merge back PR because it contains an unexpected and unwanted change to main.

@davfost davfost closed this Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants