Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-staging] Add workflow to prevent merging a PR when the NO-MERGE label is applied #111961

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 29, 2025

Backport of #111940 to release/9.0-staging

Infra only. Workflow that already works on main that prevents merging a PR when the NO-MERGE label is applied.

Edit - Confirmed it works in this PR:

image

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 29, 2025
@carlossanlop carlossanlop added Servicing-approved Approved for servicing release area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 29, 2025
@carlossanlop carlossanlop self-assigned this Jan 29, 2025
@carlossanlop carlossanlop added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 29, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@carlossanlop carlossanlop removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Jan 29, 2025
@carlossanlop carlossanlop requested a review from a team January 29, 2025 18:56
@danmoseley danmoseley added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) and removed NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) labels Jan 29, 2025
@carlossanlop
Copy link
Member

I see the utility of having this in servicing for now. The change was easy to make and we can temporarily have it here while we work on the arcade solution for everyone. When that happens, and we backport it to 9.0 and 8.0 in arcade, we can then remove this runtime-specific workflows to use the arcade one instead.

@carlossanlop carlossanlop merged commit 62d433f into release/9.0-staging Jan 29, 2025
30 of 35 checks passed
@carlossanlop carlossanlop deleted the backport/pr-111940-to-release/9.0-staging branch January 29, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure Servicing-approved Approved for servicing release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants