Fix handler when install script makes an incomplete install #2106
+159
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagilson
force-pushed
the
nagilson-fix-missing-dir
branch
from
281c44d to
f320a62
Compare
nagilson
commented
Feb 13, 2025
| @@ -69,6 +70,13 @@ You will need to restart VS Code after these changes. If PowerShell is still not | |||
| windowsFullCommand = windowsFullCommand.replace('powershell.exe', powershellReference); | |||
| } | |||
|
|
|||
|
|
|||
| // The install script can leave behind a directory in an invalid install state. Make sure the executable is present at the very least. | |||
| if (this.fileUtilities.existsSync(installContext.installDir) && !this.fileUtilities.existsSync(path.join(installContext.installDir, getDotnetExecutable()))) | |||
There was a problem hiding this comment.
What if it failed to write all of the binary? might wanna check that executing this also gives a 0 status code like dotnet --info or smth if it does exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2059