-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ListView): support IsTriggerByPagination parameter #5513
Conversation
Reviewer's Guide by SourceryThis pull request renames the Updated class diagram for ListView componentclassDiagram
class ListView {
-bool IsPagination
-bool Pageable
+Task QueryAsync(int pageIndex = 1, bool triggerByPagination = false)
+Task QueryData(bool triggerByPagination = false)
}
note for ListView "Pageable is deprecated, use IsPagination instead"
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the deprecated
Pageable
property in a future release. - Good job on including a triggerByPagination flag to differentiate between pagination and initial queries.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5513 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 649
Lines 29563 29566 +3
Branches 4165 4165
=========================================
+ Hits 29563 29566 +3 ☔ View full report in Codecov by Sentry. |
Link issues
fixes #5505
Summary By Copilot
This pull request introduces several changes to the
ListView
component and its unit tests, primarily focused on renaming a parameter for pagination and enhancing the query functionality. The most important changes include replacing thePageable
parameter withIsPagination
, updating related logic, and modifying unit tests to reflect these changes.Changes to
ListView
component:src/BootstrapBlazor.Server/Components/Samples/ListViews.razor
: Replaced thePageable
parameter withIsPagination
in theListView
component.src/BootstrapBlazor/Components/ListView/ListView.razor
: Updated conditional checks and logic to useIsPagination
instead ofPageable
.src/BootstrapBlazor/Components/ListView/ListView.razor.cs
: Deprecated thePageable
parameter, addedIsPagination
parameter, and updated query methods to include atriggerByPagination
flag. [1] [2]Changes to unit tests:
test/UnitTest/Components/ListViewTest.cs
: Updated unit tests to useIsPagination
instead ofPageable
, added assertions fortriggerByPagination
flag, and modified tests to be asynchronous where necessary. [1] [2] [3] [4] [5] [6] [7] [8]Regression?
[If yes, specify the version the behavior has regressed from]
[是否影响老版本]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Updates the ListView component to use IsPagination instead of the deprecated Pageable parameter for controlling pagination, and adds a triggerByPagination flag to the query methods.
Enhancements: