refactor(AutoComplete): improved the TriggerChange/TriggerFilter method to update CurrentValue

[celadaris]

Link issues

[请在下方 # 后面填写相关 Issue 编号，如 #42]
fixes #5110
fixes #5532

Summary By Copilot

This pull request includes updates to the BootstrapBlazor project, focusing on upgrading the version and improving the AutoComplete component. The most important changes include updating the project version, translating comments and documentation from Chinese to English, and enhancing the TriggerFilter and TriggerChange methods to prevent overwriting user input.

Project version update:

• src/BootstrapBlazor/BootstrapBlazor.csproj: Updated the project version from 9.4.6 to 9.4.7-beta01.

Translations:

• src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs: Translated all comments and documentation from Chinese to English to improve code readability and maintainability. [1] [2] [3]

Method enhancements:

• src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs: Enhanced the TriggerFilter method to store the current input value and prevent it from being overwritten, and only trigger StateHasChanged if no binding is present.
• src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs: Improved the TriggerChange method to update CurrentValue only if the value has actually changed, preventing overwriting the user's input.

Regression?

• Yes
• No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

• High
• Medium
• Low

[Justify the selection above]

Verification

• Manual (required)
• Automated

Packaging changes reviewed?

• Yes
• No
• N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated/provided or not needed
• Demo is updated/provided or not needed
• Merge the latest code from the main branch

Summary by Sourcery

Fixes an issue where the input value in the AutoComplete component was being overwritten during filtering, preventing proper updates and maintaining the correct user input. The fix ensures that the CurrentValue is only updated if the value has actually changed and uses the current input value to prevent overwriting.

Bug Fixes:

• Fixes an issue where the input value in the AutoComplete component was being overwritten during filtering.
• Ensures that the CurrentValue is only updated if the value has actually changed to prevent overwriting the user's input.
• Uses the current input value during filtering to prevent overwriting.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue where the input value in the AutoComplete component was being overwritten during filtering and change events. The changes ensure that the current input value is preserved and only updated when necessary, preventing unexpected behavior.

Sequence diagram for TriggerFilter method

sequenceDiagram
    participant AutoComplete
    AutoComplete->>AutoComplete: Store current input value
    AutoComplete->>AutoComplete: Filter items based on input value
    AutoComplete->>AutoComplete: Take top DisplayCount items
    AutoComplete->>AutoComplete: Set CurrentValue to currentInputValue
    alt ValueChanged.HasDelegate is false
        AutoComplete->>AutoComplete: StateHasChanged()
    end

Loading

File-Level Changes

Change	Details	Files
Prevented overwriting the input value in TriggerFilter and TriggerChange methods.	Stored the current input value in TriggerFilter to prevent overwriting. Used the stored currentInputValue when setting CurrentValue in TriggerFilter. Added a check in TriggerChange to update CurrentValue only if the value has changed.	src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs

Possibly linked issues

• bug(AutoComplete): interrupt input cause network delay #5110: The PR fixes the issue by adding logic to handle DisplayCount correctly even when OnFocusFilter is false. The changes ensure that the correct number of items are displayed in the AutoComplete dropdown.
• bug(AutoComplete): interrupt input cause network delay #5110: The PR fixes the bug described in the issue by filtering key presses before calling OnCustomFilter.
• bug(AutoComplete): interrupt input cause network delay #5110: The PR fixes the issue by preventing the input value from being overwritten and only calling StateHasChanged when no binding is present. This addresses the infinite OnCustomFilter execution.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[bb-auto]

Thanks for your PR, @celadaris. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[sourcery-ai]

Hey @celadaris - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider extracting the conditional StateHasChanged call into a separate method to improve readability.
• It looks like TriggerChange and TriggerFilter have very similar logic - could this be refactored?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5ddb33d) to head (032815c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #5531   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          649       649           
  Lines        29599     29607    +8     
  Branches      4171      4173    +2     
=========================================
+ Hits         29599     29607    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[celadaris]

@microsoft-github-policy-service agree